From: Dan Carpenter <dan.carpenter@oracle.com>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH] tee: amdtee: fix an IS_ERR() vs NULL bug
Date: Mon, 29 Nov 2021 11:54:04 +0300 [thread overview]
Message-ID: <20211129085404.GQ18178@kadam> (raw)
In-Reply-To: <tencent_F4542B974E00912E031D1999D6D98F8C9006@qq.com>
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
On Mon, Nov 29, 2021 at 04:31:51PM +0800, 994605959 wrote:
> maybe try this?
> - if (IS_ERR(*ta)) {
> - pr_err("%s: get_free_pages failed 0x%llx\n", __func__,
> - (u64)*ta);
> + if (IS_ERR(ta)) {
> + pr_err("%s: get_free_pages failed %p\n", __func__, ta);
No, what you are suggesting is totally wrong. You are checking the
wrong variable for the wrong thing.
regards,
dan carpenter
next parent reply other threads:[~2021-11-29 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_F4542B974E00912E031D1999D6D98F8C9006@qq.com>
2021-11-29 8:54 ` Dan Carpenter [this message]
[not found] <=?utf-8?q?=3CCH0PR12MB5346CA4DBE99A795A1B6CA48CF669=40CH0PR12MB?= =?utf-8?q?5346=2Enamprd12=2Eprod=2Eoutlook=2Ecom=3E?=>
2021-11-30 7:00 ` [PATCH] tee: amdtee: fix an IS_ERR() vs NULL bug Jens Wiklander
2021-11-24 14:54 Dan Carpenter
2021-11-29 8:23 ` Thomas, Rijo-john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129085404.GQ18178@kadam \
--to=dan.carpenter@oracle.com \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox