From: Christoph Hellwig <hch@lst.de>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH 2/4] tee: Remove vmalloc page support
Date: Mon, 10 Oct 2022 09:42:34 +0200 [thread overview]
Message-ID: <20221010074234.GA20788@lst.de> (raw)
In-Reply-To: < <CAHk-=whVyH-wSWLd=Zn4rwo+91T+qzRvfMPC2yFX98GxykOqOw@mail.gmail.com>>
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
On Thu, Oct 06, 2022 at 11:20:16AM -0700, Linus Torvalds wrote:
> Actually, I think even then we shouldn't support vmalloc - and
> register_shm_helper() just needs to be changed to pass in an array of
> actual page pointers instead.
>
> At that point TEE_SHM_USER_MAPPED should also go away, because then
> it's the caller that should just do either the user space page
> pinning, or pass in the kernel page pointer.
>
> JensW, is there some reason that wouldn't work?
I suspect the best long term option would be to just pass an iov_iter..
next prev parent reply other threads:[~2022-10-10 7:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] < <CAHk-=whVyH-wSWLd=Zn4rwo+91T+qzRvfMPC2yFX98GxykOqOw@mail.gmail.com>
2022-10-07 8:12 ` [PATCH 2/4] tee: Remove vmalloc page support Jens Wiklander
2022-10-10 7:42 ` Christoph Hellwig [this message]
2022-10-10 17:20 ` Linus Torvalds
[not found] < <CAFA6WYNMRymyqkqfASYAPVoL0iR2kw0h9YKZ1gBTdeSuHMOAtQ@mail.gmail.com>
2022-12-16 8:45 ` Sumit Garg
[not found] < <CAHUa44GkTLCzuSij5FbjBXFBM1CCQROtrCtHHtj70ZRi-3K7uA@mail.gmail.com>
2022-12-16 0:41 ` Ira Weiny
2022-12-16 5:09 ` Sumit Garg
2022-12-16 7:06 ` Christoph Hellwig
[not found] < <CAHk-=whvmR98OHdYf4yOJgp86hq0VMVXJ9b1Qk7P_Rjq_=HU+A@mail.gmail.com>
2022-10-10 17:57 ` Al Viro
[not found] < <CAFA6WYMT9S1Di6DN_UXc823f0ZTkqerE1PB=oG6wmfx28vEbDg@mail.gmail.com>
2022-10-06 18:19 ` Ira Weiny
2022-10-06 18:20 ` Linus Torvalds
[not found] <=?utf-8?q?=3CTYZPR03MB65279558CC22F5130B710EA8FB5D9=40TYZPR03MB?= =?utf-8?q?6527=2Eapcprd03=2Eprod=2Eoutlook=2Ecom=3E?=>
2022-10-06 6:23 ` Sumit Garg
2022-10-02 0:23 [PATCH 0/4] Remove get_kernel_pages() ira.weiny
2022-10-02 0:23 ` [PATCH 2/4] tee: Remove vmalloc page support ira.weiny
2022-10-03 6:41 ` Jens Wiklander
2022-10-03 6:57 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010074234.GA20788@lst.de \
--to=hch@lst.de \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox