From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.trustedfirmware.org (lists.trustedfirmware.org [18.214.241.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F3A2E63F06 for ; Sun, 15 Feb 2026 17:54:16 +0000 (UTC) Received: from lists.trustedfirmware.org (localhost [127.0.0.1]) by lists.trustedfirmware.org (Postfix) with ESMTP id 5059043848 for ; Sun, 15 Feb 2026 17:54:15 +0000 (UTC) Authentication-Results: lists.trustedfirmware.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=BvNCg8+E; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by lists.trustedfirmware.org (Postfix) with ESMTPS id 7AFC2436F1 for ; Sun, 15 Feb 2026 17:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771178034; x=1802714034; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fbTqBfpJWT1VLT7NCAQflJCxsq4/aL+pljR7u4c1CQk=; b=BvNCg8+ELAniBOlmN5j0uNa+4IWw8oxNM7RCm3jgY2/NzhjM+8VA8yr1 pk8RJ50+isiYRdTZhDDq//JKjyIMR6HxW/8/uq0EsWiSjq3Xf9b7PC9gM 72iEyYrmslAN0V/hHDMxqe9B8kqmzkn/4954UCls37yRj3U8IYMH7/ZNI xkzrBhbTcjAfSTm9vFUdr31vhC4Z+YaX6+Vr9ETb6Vf6vMgG6SQQhQzop 3gYT6g+RVqA/LPeAoD+Fz1R7ig8Vb41uTLoHE5dD/M76GJm/pXQWd/Awa pghHe+L1kY+CyrsC9qhSsKVbyao5FWge7iiubXUXx2hwrOkHhPylkdLYW w==; X-CSE-ConnectionGUID: eQW155/FRd62k4VD8whcEw== X-CSE-MsgGUID: tOZEV4X4QPmgLCzXWL+0iw== X-IronPort-AV: E=McAfee;i="6800,10657,11702"; a="75902228" X-IronPort-AV: E=Sophos;i="6.21,292,1763452800"; d="scan'208";a="75902228" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2026 09:53:53 -0800 X-CSE-ConnectionGUID: cjIp6V0CRteGCYtzMakkIg== X-CSE-MsgGUID: UvHeBzLxTRSBbY8j9iWUMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,292,1763452800"; d="scan'208";a="212449287" Received: from lkp-server01.sh.intel.com (HELO 765f4a05e27f) ([10.239.97.150]) by fmviesa010.fm.intel.com with ESMTP; 15 Feb 2026 09:53:50 -0800 Received: from kbuild by 765f4a05e27f with local (Exim 4.98.2) (envelope-from ) id 1vrgJX-00000000yyg-1g5O; Sun, 15 Feb 2026 17:53:47 +0000 Date: Mon, 16 Feb 2026 01:53:32 +0800 From: kernel test robot To: Sumit Garg , op-tee@lists.trustedfirmware.org Subject: Re: [RFT PATCH] tee: shm: Remove refcounting of kernel pages Message-ID: <202602160147.pGHOLa5U-lkp@intel.com> References: <20260213113317.1728769-1-sumit.garg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260213113317.1728769-1-sumit.garg@kernel.org> X-Rspamd-Action: no action X-Spamd-Result: default: False [-7.00 / 15.00]; WHITELIST_SPF_DKIM(-3.00)[intel.com:d:+,intel.com:s:+]; BAYES_HAM(-3.00)[100.00%]; DWL_DNSWL_LOW(-1.00)[intel.com:dkim]; MID_CONTAINS_FROM(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[intel.com,none]; R_SPF_ALLOW(-0.20)[+ip4:198.175.65.0/26]; R_DKIM_ALLOW(-0.20)[intel.com:s=Intel]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:4983, ipnet:198.175.64.0/23, country:US]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; NEURAL_HAM(-0.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[intel.com:+] X-Rspamd-Server: lists.trustedfirmware.org X-Rspamd-Queue-Id: 7AFC2436F1 X-Spamd-Bar: ------- Message-ID-Hash: RFC5FNFWJ4CTLY6HI6QNLHZNGRZ6DBVM X-Message-ID-Hash: RFC5FNFWJ4CTLY6HI6QNLHZNGRZ6DBVM X-MailFrom: lkp@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-op-tee.lists.trustedfirmware.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: oe-kbuild-all@lists.linux.dev, vbabka@suse.cz, akpm@linux-foundation.org, willy@infradead.org, linux-kernel@vger.kernel.org, Sumit Garg , Marco Felsch , Sven =?iso-8859-1?Q?P=FCschel?= X-Mailman-Version: 3.3.5 Precedence: list List-Id: Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Sumit, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.19 next-20260213] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sumit-Garg/tee-shm-Remove-refcounting-of-kernel-pages/20260213-193435 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20260213113317.1728769-1-sumit.garg%40kernel.org patch subject: [RFT PATCH] tee: shm: Remove refcounting of kernel pages config: loongarch-randconfig-r071-20260214 (https://download.01.org/0day-ci/archive/20260216/202602160147.pGHOLa5U-lkp@intel.com/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) rustc: rustc 1.88.0 (6b00bc388 2025-06-23) smatch version: v0.5.0-8994-gd50c5a4c reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260216/202602160147.pGHOLa5U-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202602160147.pGHOLa5U-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/tee/tee_shm.c:475:6: error: call to undeclared function 'iter_is_uvec'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 475 | if (iter_is_uvec(iter)) | ^ drivers/tee/tee_shm.c:475:6: note: did you mean 'iter_is_iovec'? include/linux/uio.h:128:20: note: 'iter_is_iovec' declared here 128 | static inline bool iter_is_iovec(const struct iov_iter *i) | ^ 1 error generated. vim +/iter_is_uvec +475 drivers/tee/tee_shm.c 399 400 static struct tee_shm * 401 register_shm_helper(struct tee_context *ctx, struct iov_iter *iter, u32 flags, 402 int id) 403 { 404 struct tee_device *teedev = ctx->teedev; 405 struct tee_shm *shm; 406 unsigned long start, addr; 407 size_t num_pages, off; 408 ssize_t len; 409 void *ret; 410 int rc; 411 412 if (!tee_device_get(teedev)) 413 return ERR_PTR(-EINVAL); 414 415 if (!teedev->desc->ops->shm_register || 416 !teedev->desc->ops->shm_unregister) { 417 ret = ERR_PTR(-ENOTSUPP); 418 goto err_dev_put; 419 } 420 421 teedev_ctx_get(ctx); 422 423 shm = kzalloc(sizeof(*shm), GFP_KERNEL); 424 if (!shm) { 425 ret = ERR_PTR(-ENOMEM); 426 goto err_ctx_put; 427 } 428 429 refcount_set(&shm->refcount, 1); 430 shm->flags = flags; 431 shm->ctx = ctx; 432 shm->id = id; 433 addr = untagged_addr((unsigned long)iter_iov_addr(iter)); 434 start = rounddown(addr, PAGE_SIZE); 435 num_pages = iov_iter_npages(iter, INT_MAX); 436 if (!num_pages) { 437 ret = ERR_PTR(-ENOMEM); 438 goto err_ctx_put; 439 } 440 441 shm->pages = kcalloc(num_pages, sizeof(*shm->pages), GFP_KERNEL); 442 if (!shm->pages) { 443 ret = ERR_PTR(-ENOMEM); 444 goto err_free_shm; 445 } 446 447 len = iov_iter_extract_pages(iter, &shm->pages, LONG_MAX, num_pages, 0, 448 &off); 449 if (unlikely(len <= 0)) { 450 ret = len ? ERR_PTR(len) : ERR_PTR(-ENOMEM); 451 goto err_free_shm_pages; 452 } else if (DIV_ROUND_UP(len + off, PAGE_SIZE) != num_pages) { 453 /* 454 * If we only got a few pages, update to release the 455 * correct amount below. 456 */ 457 shm->num_pages = len / PAGE_SIZE; 458 ret = ERR_PTR(-ENOMEM); 459 goto err_put_shm_pages; 460 } 461 462 shm->offset = off; 463 shm->size = len; 464 shm->num_pages = num_pages; 465 466 rc = teedev->desc->ops->shm_register(ctx, shm, shm->pages, 467 shm->num_pages, start); 468 if (rc) { 469 ret = ERR_PTR(rc); 470 goto err_put_shm_pages; 471 } 472 473 return shm; 474 err_put_shm_pages: > 475 if (iter_is_uvec(iter)) 476 unpin_user_pages(shm->pages, shm->num_pages); 477 err_free_shm_pages: 478 kfree(shm->pages); 479 err_free_shm: 480 kfree(shm); 481 err_ctx_put: 482 teedev_ctx_put(ctx); 483 err_dev_put: 484 tee_device_put(teedev); 485 return ret; 486 } 487 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki