From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rouven Czerwinski To: op-tee@lists.trustedfirmware.org Subject: Re: [PATCH] tee: optee: remove need_resched() before cond_resched() Date: Fri, 29 Jan 2021 14:42:44 +0100 Message-ID: <6cbc0636-1465-9cc4-87ca-3f78d8f67775@pengutronix.de> In-Reply-To: < > MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5551545098979675407==" List-Id: --===============5551545098979675407== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On 29.01.21 14:29, Jens Wiklander wrote: > Hi Rouven and Sumit, > > On Mon, Jan 25, 2021 at 10:58 AM Jens Wiklander via OP-TEE > wrote: >> >> Hi Rouven and Sumit, >> >> On Mon, Jan 25, 2021 at 10:55 AM Jens Wiklander >> wrote: >>> >>> Testing need_resched() before cond_resched() is not needed as an >>> equivalent test is done internally in cond_resched(). So drop the >>> need_resched() test. >>> >>> Fixes: dcb3b06d9c34 ("tee: optee: replace might_sleep with cond_resched") >>> Signed-off-by: Jens Wiklander >>> --- >>> drivers/tee/optee/call.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> Can you please test to see that this works in your setups too? > > Does this work for you? I'd like to get this patch ready for v5.12. Sorry I did not get to this yet, I'll need to modify the existing kernelconfig again to reproduce the buggy configuration. I'll get this done by monday. Regards, Rouven --===============5551545098979675407==--