* Re: [PATCH v3 01/11] tee: allow a driver to allocate a tee_device without a pool [not found] <=?utf-8?q?=3C20250327-qcom-tee-using-tee-ss-without-mem-obj-v3-?= =?utf-8?q?1-7f457073282d=40oss=2Equalcomm=2Ecom=3E?=> @ 2025-04-21 10:18 ` Sumit Garg 0 siblings, 0 replies; 2+ messages in thread From: Sumit Garg @ 2025-04-21 10:18 UTC (permalink / raw) To: op-tee [-- Attachment #1: Type: text/plain, Size: 1147 bytes --] On Thu, Mar 27, 2025 at 07:47:23PM -0700, Amirreza Zarrabi wrote: > A TEE driver doesn't always need to provide a pool if it doesn't > support memory sharing ioctls and can allocate memory for TEE > messages in another way. Although this is mentioned in the > documentation for tee_device_alloc(), it is not handled correctly. > > Signed-off-by: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com> > --- > drivers/tee/tee_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com> -Sumit > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > index d113679b1e2d..24edce4cdbaa 100644 > --- a/drivers/tee/tee_core.c > +++ b/drivers/tee/tee_core.c > @@ -888,7 +888,7 @@ struct tee_device *tee_device_alloc(const struct tee_desc *teedesc, > > if (!teedesc || !teedesc->name || !teedesc->ops || > !teedesc->ops->get_version || !teedesc->ops->open || > - !teedesc->ops->release || !pool) > + !teedesc->ops->release) > return ERR_PTR(-EINVAL); > > teedev = kzalloc(sizeof(*teedev), GFP_KERNEL); > > -- > 2.34.1 > > ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <=?utf-8?q?=3C20250327-qcom-tee-using-tee-ss-without-mem-obj-v3-?= =?utf-8?q?0-7f457073282d=40oss=2Equalcomm=2Ecom=3E?=>]
* [PATCH v3 01/11] tee: allow a driver to allocate a tee_device without a pool [not found] <=?utf-8?q?=3C20250327-qcom-tee-using-tee-ss-without-mem-obj-v3-?= =?utf-8?q?0-7f457073282d=40oss=2Equalcomm=2Ecom=3E?=> @ 2025-03-28 2:47 ` Amirreza Zarrabi 0 siblings, 0 replies; 2+ messages in thread From: Amirreza Zarrabi @ 2025-03-28 2:47 UTC (permalink / raw) To: op-tee [-- Attachment #1: Type: text/plain, Size: 954 bytes --] A TEE driver doesn't always need to provide a pool if it doesn't support memory sharing ioctls and can allocate memory for TEE messages in another way. Although this is mentioned in the documentation for tee_device_alloc(), it is not handled correctly. Signed-off-by: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com> --- drivers/tee/tee_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c index d113679b1e2d..24edce4cdbaa 100644 --- a/drivers/tee/tee_core.c +++ b/drivers/tee/tee_core.c @@ -888,7 +888,7 @@ struct tee_device *tee_device_alloc(const struct tee_desc *teedesc, if (!teedesc || !teedesc->name || !teedesc->ops || !teedesc->ops->get_version || !teedesc->ops->open || - !teedesc->ops->release || !pool) + !teedesc->ops->release) return ERR_PTR(-EINVAL); teedev = kzalloc(sizeof(*teedev), GFP_KERNEL); -- 2.34.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-21 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <=?utf-8?q?=3C20250327-qcom-tee-using-tee-ss-without-mem-obj-v3-?= =?utf-8?q?1-7f457073282d=40oss=2Equalcomm=2Ecom=3E?=>
2025-04-21 10:18 ` [PATCH v3 01/11] tee: allow a driver to allocate a tee_device without a pool Sumit Garg
[not found] <=?utf-8?q?=3C20250327-qcom-tee-using-tee-ss-without-mem-obj-v3-?= =?utf-8?q?0-7f457073282d=40oss=2Equalcomm=2Ecom=3E?=>
2025-03-28 2:47 ` Amirreza Zarrabi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox