Re: [PATCH v1 16/17] tpm/tpm_ftpm_tee: Make use of tee specific driver registration

Sumit Garg via OP-TEE
2025-12-15T07:38:55Z

On Thu, Dec 11, 2025 at 06:15:10PM +0100, Uwe Kleine-König wrote:
> tee_client_driver_register() is typed more strongly and cares about
> assigning the driver's bus. Similar for tee_client_driver_unregister().
>
> Make use of these functions.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> drivers/char/tpm/tpm_ftpm_tee.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

>
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> index 4e63c30aeaf1..e5fbc70b0eca 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.c
> +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> @@ -338,7 +338,6 @@ static struct tee_client_driver ftpm_tee_driver = {
> .id_table = optee_ftpm_id_table,
> .driver = {
> .name = "optee-ftpm",
> - .bus = &tee_bus_type,
> .probe = ftpm_tee_probe,
> .remove = ftpm_tee_remove,
> },
> @@ -352,7 +351,7 @@ static int __init ftpm_mod_init(void)
> if (rc)
> return rc;
>
> - rc = driver_register(&ftpm_tee_driver.driver);
> + rc = tee_client_driver_register(&ftpm_tee_driver);
> if (rc) {
> platform_driver_unregister(&ftpm_tee_plat_driver);
> return rc;
> @@ -364,7 +363,7 @@ static int __init ftpm_mod_init(void)
> static void __exit ftpm_mod_exit(void)
> {
> platform_driver_unregister(&ftpm_tee_plat_driver);
> - driver_unregister(&ftpm_tee_driver.driver);
> + tee_client_driver_unregister(&ftpm_tee_driver);
> }
>
> module_init(ftpm_mod_init);
> --
> 2.47.3
>
>