build breakage with SCMI

build breakage with SCMI

[Dan Carpenter]

When I try building with `make run WITH_SCMI=y` then the build fails:

core/lib/scmi-server/scmi_server.c: In function ‘scmi_server_initialize’:
core/lib/scmi-server/scmi_server.c:83:22: error: implicit declaration of function ‘scmi_configure’ [-Wimplicit-function-declaration]
   83 |                 rc = scmi_configure(cfg);
      |                      ^~~~~~~~~~~~~~

This was introduced in commit ce6ea4112008 ("scmi-server: configure
SCP-firmware from DT").  A grep for scmi_configure() turns up empty.
Was part of the commit missing?

regards,
dan carpenter

Re: build breakage with SCMI

[Jerome Forissier]

Hi Dan,

On 12/15/25 20:02, Dan Carpenter wrote:
> When I try building with `make run WITH_SCMI=y` then the build fails:
> 
> core/lib/scmi-server/scmi_server.c: In function ‘scmi_server_initialize’:
> core/lib/scmi-server/scmi_server.c:83:22: error: implicit declaration of function ‘scmi_configure’ [-Wimplicit-function-declaration]
>    83 |                 rc = scmi_configure(cfg);
>       |                      ^~~~~~~~~~~~~~
> 
> This was introduced in commit ce6ea4112008 ("scmi-server: configure
> SCP-firmware from DT").  A grep for scmi_configure() turns up empty.
> Was part of the commit missing?

I suspect your SCP-firmware source tree is too old. Please see:
https://github.com/OP-TEE/optee_os/blob/master/.github/workflows/ci.yml#L226

Thanks,
-- 
Jerome

> 
> regards,
> dan carpenter
> 

Re: build breakage with SCMI

[Dan Carpenter]

On Tue, Dec 16, 2025 at 11:53:13AM +0100, Jerome Forissier wrote:
> Hi Dan,
> 
> On 12/15/25 20:02, Dan Carpenter wrote:
> > When I try building with `make run WITH_SCMI=y` then the build fails:
> > 
> > core/lib/scmi-server/scmi_server.c: In function ‘scmi_server_initialize’:
> > core/lib/scmi-server/scmi_server.c:83:22: error: implicit declaration of function ‘scmi_configure’ [-Wimplicit-function-declaration]
> >    83 |                 rc = scmi_configure(cfg);
> >       |                      ^~~~~~~~~~~~~~
> > 
> > This was introduced in commit ce6ea4112008 ("scmi-server: configure
> > SCP-firmware from DT").  A grep for scmi_configure() turns up empty.
> > Was part of the commit missing?
> 
> I suspect your SCP-firmware source tree is too old. Please see:
> https://github.com/OP-TEE/optee_os/blob/master/.github/workflows/ci.yml#L226
> 

Huh.  Thanks.  That fixes the build.  I had used this command:

repo init -u https://github.com/OP-TEE/manifest.git -m qemu_v8.xml

https://github.com/OP-TEE/manifest/blob/master/qemu_v8.xml

That manifest file checks out revision="refs/tags/v2.16.0" which doesn't
build.  Actually, all the manifest files which reference SCP are too old:

qemu_v8.xml:        <project path="SCP-firmware"         name="linaro-swg/SCP-firmware.git"             revision="refs/tags/v2.16.0" clone-depth="1" />
stm32mp1.xml:        <project path="scp-firmware"         name="firmware/SCP-firmware.git" revision="refs/tags/v2.15.0" remote="arm-gitlab" clone-depth="1" />
synquacer.xml:        <project path="SCP-firmware"         name="ARM-software/SCP-firmware.git"         revision="56d4f515bcf1bc1b843abe343e9cf9dc44898ca2" />

regards,
dan carpenter

Re: build breakage with SCMI

[Jérôme Forissier via OP-TEE]

On Tue, Dec 16, 2025 at 3:54 PM Dan Carpenter <dan.carpenter@linaro.org>
wrote:

> On Tue, Dec 16, 2025 at 11:53:13AM +0100, Jerome Forissier wrote:
> > Hi Dan,
> >
> > On 12/15/25 20:02, Dan Carpenter wrote:
> > > When I try building with `make run WITH_SCMI=y` then the build fails:
> > >
> > > core/lib/scmi-server/scmi_server.c: In function
> ‘scmi_server_initialize’:
> > > core/lib/scmi-server/scmi_server.c:83:22: error: implicit declaration
> of function ‘scmi_configure’ [-Wimplicit-function-declaration]
> > >    83 |                 rc = scmi_configure(cfg);
> > >       |                      ^~~~~~~~~~~~~~
> > >
> > > This was introduced in commit ce6ea4112008 ("scmi-server: configure
> > > SCP-firmware from DT").  A grep for scmi_configure() turns up empty.
> > > Was part of the commit missing?
> >
> > I suspect your SCP-firmware source tree is too old. Please see:
> >
> https://github.com/OP-TEE/optee_os/blob/master/.github/workflows/ci.yml#L226
> >
>
> Huh.  Thanks.  That fixes the build.  I had used this command:
>
> repo init -u https://github.com/OP-TEE/manifest.git -m qemu_v8.xml
>
> https://github.com/OP-TEE/manifest/blob/master/qemu_v8.xml
>
> That manifest file checks out revision="refs/tags/v2.16.0" which doesn't
> build.  Actually, all the manifest files which reference SCP are too old:
>
> qemu_v8.xml:        <project path="SCP-firmware"
>  name="linaro-swg/SCP-firmware.git"
>  revision="refs/tags/v2.16.0" clone-depth="1" />
> stm32mp1.xml:        <project path="scp-firmware"
>  name="firmware/SCP-firmware.git" revision="refs/tags/v2.15.0"
> remote="arm-gitlab" clone-depth="1" />
> synquacer.xml:        <project path="SCP-firmware"
>  name="ARM-software/SCP-firmware.git"
>  revision="56d4f515bcf1bc1b843abe343e9cf9dc44898ca2" />
>
>
The latest release tag I can see on GitLab is v2.16.0, do you know if there
is going to be a release soon? In this case we could wait before updating
the manifests. Otherwise, using a SHA-1 is fine.
Would you mind creating a pull request?

Thanks,
-- 
Jerome

regards,
> dan carpenter
>
>