From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jerome Forissier <jerome.forissier@linaro.org>
Cc: Valentin Caron <valentin.caron@foss.st.com>,
op-tee@lists.trustedfirmware.org
Subject: Re: build breakage with SCMI
Date: Tue, 16 Dec 2025 17:54:20 +0300 [thread overview]
Message-ID: <aUFynAjN13O_ai_P@stanley.mountain> (raw)
In-Reply-To: <f76a7766-08b9-4bc9-9d04-0ed61087ccc0@linaro.org>
On Tue, Dec 16, 2025 at 11:53:13AM +0100, Jerome Forissier wrote:
> Hi Dan,
>
> On 12/15/25 20:02, Dan Carpenter wrote:
> > When I try building with `make run WITH_SCMI=y` then the build fails:
> >
> > core/lib/scmi-server/scmi_server.c: In function ‘scmi_server_initialize’:
> > core/lib/scmi-server/scmi_server.c:83:22: error: implicit declaration of function ‘scmi_configure’ [-Wimplicit-function-declaration]
> > 83 | rc = scmi_configure(cfg);
> > | ^~~~~~~~~~~~~~
> >
> > This was introduced in commit ce6ea4112008 ("scmi-server: configure
> > SCP-firmware from DT"). A grep for scmi_configure() turns up empty.
> > Was part of the commit missing?
>
> I suspect your SCP-firmware source tree is too old. Please see:
> https://github.com/OP-TEE/optee_os/blob/master/.github/workflows/ci.yml#L226
>
Huh. Thanks. That fixes the build. I had used this command:
repo init -u https://github.com/OP-TEE/manifest.git -m qemu_v8.xml
https://github.com/OP-TEE/manifest/blob/master/qemu_v8.xml
That manifest file checks out revision="refs/tags/v2.16.0" which doesn't
build. Actually, all the manifest files which reference SCP are too old:
qemu_v8.xml: <project path="SCP-firmware" name="linaro-swg/SCP-firmware.git" revision="refs/tags/v2.16.0" clone-depth="1" />
stm32mp1.xml: <project path="scp-firmware" name="firmware/SCP-firmware.git" revision="refs/tags/v2.15.0" remote="arm-gitlab" clone-depth="1" />
synquacer.xml: <project path="SCP-firmware" name="ARM-software/SCP-firmware.git" revision="56d4f515bcf1bc1b843abe343e9cf9dc44898ca2" />
regards,
dan carpenter
next prev parent reply other threads:[~2025-12-16 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 19:02 build breakage with SCMI Dan Carpenter
2025-12-16 10:53 ` Jerome Forissier
2025-12-16 14:54 ` Dan Carpenter [this message]
2025-12-17 12:23 ` Jérôme Forissier via OP-TEE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUFynAjN13O_ai_P@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=valentin.caron@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox