From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.trustedfirmware.org (lists.trustedfirmware.org [18.214.241.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29EA1CD342C for ; Mon, 4 May 2026 11:23:52 +0000 (UTC) Received: from lists.trustedfirmware.org (localhost [127.0.0.1]) by lists.trustedfirmware.org (Postfix) with ESMTP id 5D7BB44E08 for ; Mon, 4 May 2026 11:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.trustedfirmware.org; s=2024; t=1777893831; bh=1w+MzSobxxhh4/Z6BnF1Kps4Ui5Z89S5baW8VF7cW6E=; h=Date:To:Subject:References:In-Reply-To:CC:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Reply-To:From; b=bQpuJImsnt7D/51pftEXaVGYYZMn4KnRsV/ZqjWubACvvMBDb7TOWUKUn+YSYgUyv shpquGvL/1fyf7ZCBRH730P8CuDC6fZ9cd6t97qq+RPnSEvl1m6Z0UQfwktbAYogk6 68xwxSujqajRotUSZShD0pnaHk7hV0YeIoHymKN/hAtEeMOaTNeiqDw2E3iawQfvdt yyI+fy1JGsk+jCc78SiQ25+YCGojIoM0zpc9QhgAe8ufIt7Sxej4TYLneXNntzh7vQ G3YDCWUIOASTTIcFCF+5w8mXkbf/N8ixodEfotB/5DQX/LoiYv8Bjqnkc/zjUU8Qyd LhCtUzQlrbzcQ== Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by lists.trustedfirmware.org (Postfix) with ESMTPS id C06E742F1B for ; Mon, 4 May 2026 11:23:44 +0000 (UTC) Authentication-Results: lists.trustedfirmware.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bKjpZmuv; dkim-atps=neutral Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 1F2A043DA9; Mon, 4 May 2026 11:23:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17416C2BCB8; Mon, 4 May 2026 11:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777893824; bh=1w+MzSobxxhh4/Z6BnF1Kps4Ui5Z89S5baW8VF7cW6E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bKjpZmuvT3AASZNwdOzNxp2knijQMyMENFMHM5uqAOrV+70C3W/V+G62NSkeLnjzL d7IH3uPHFHyq6SvUwEUCu6X33eAaaVpuGEI+NWlgvBQgKDyKKsXmUsMFbxJTZk5XmB Lo3jNju8AYgqS3cynz2WeFDWRkxL7rvgwSY5jsqgL9E7bn8S4dT+McwB5oeSR6cyY8 GE5Y1kovSElzmwnbUck5r3saI9Xt0dB57LfWOdOonvUwnNHfNwZ0RJwogibRCtfsn8 L4L0/hTuWlEatyhi8lNXCX9h5krZSukJ7LkRsewUB1J58/zkoNMLAc9tK7EMOodhSX SWLdQcNbZAOaQ== Date: Mon, 4 May 2026 16:53:26 +0530 To: Mukesh Ojha Subject: Re: [PATCH v4 03/15] firmware: qcom_scm: Migrate to generic PAS service Message-ID: References: <20260427095603.1157963-1-sumit.garg@kernel.org> <20260427095603.1157963-4-sumit.garg@kernel.org> <20260429104841.l555xd2izoyrqjp4@hu-mojha-hyd.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Spamd-Result: default: False [-2.00 / 15.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,quarantine]; MID_RHS_NOT_FQDN(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:172.234.252.31]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:63949, ipnet:172.234.224.0/19, country:SG]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[49]; FREEMAIL_CC(0.00)[kernel.org,vger.kernel.org,lists.freedesktop.org,lists.infradead.org,oss.qualcomm.com,poorly.run,linux.dev,gmail.com,somainline.org,ffwll.ch,lunn.ch,davemloft.net,google.com,redhat.com,linaro.org,qti.qualcomm.com,lists.trustedfirmware.org]; TAGGED_RCPT(0.00)[dt,netdev]; DWL_DNSWL_BLOCKED(0.00)[kernel.org:dkim]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM(-0.00)[-1.000]; ALIAS_RESOLVED(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+] X-Rspamd-Server: lists.trustedfirmware.org X-Rspamd-Queue-Id: C06E742F1B X-Spamd-Bar: - Message-ID-Hash: Q4N56EEN6AUU2IU4YSLYXWBAQFM66PPV X-Message-ID-Hash: Q4N56EEN6AUU2IU4YSLYXWBAQFM66PPV X-MailFrom: sumit.garg@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-op-tee.lists.trustedfirmware.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanat han@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg X-Mailman-Version: 3.3.5 Precedence: list List-Id: Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Sumit Garg via OP-TEE Reply-To: Sumit Garg On Fri, May 01, 2026 at 07:11:19PM +0530, Sumit Garg wrote: > On Wed, Apr 29, 2026 at 04:18:41PM +0530, Mukesh Ojha wrote: > > On Mon, Apr 27, 2026 at 03:25:51PM +0530, Sumit Garg wrote: > > > From: Sumit Garg > > > > > > With the availability of generic PAS service, let's add SCM calls as > > > a backend to keep supporting legacy QTEE interfaces. The exported > > > qcom_scm* wrappers will get dropped once all the client drivers get > > > migrated as part of future patches. > > > > > > Signed-off-by: Sumit Garg > > > --- > > > drivers/firmware/qcom/Kconfig | 1 + > > > drivers/firmware/qcom/qcom_scm.c | 335 ++++++++++++++----------------- > > > 2 files changed, 155 insertions(+), 181 deletions(-) > > > > > > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c > > > index 9b06a69d3a6d..d87a962e93da 100644 > > > --- a/drivers/firmware/qcom/qcom_scm.c > > > +++ b/drivers/firmware/qcom/qcom_scm.c > > > > > > -/** > > > - * qcom_scm_pas_shutdown() - Shut down the remote processor > > > - * @pas_id: peripheral authentication service id > > > - * > > > - * Returns 0 on success. > > > - */ > > > -int qcom_scm_pas_shutdown(u32 pas_id) > > > +static int __qcom_scm_pas_set_remote_state(struct device *dev, u32 state, > > > + u32 pas_id) > > > +{ > > > + struct qcom_scm_desc desc = { > > > + .svc = QCOM_SCM_SVC_BOOT, > > > + .cmd = QCOM_SCM_BOOT_SET_REMOTE_STATE, > > > + .arginfo = QCOM_SCM_ARGS(2), > > > + .args[0] = state, > > > + .args[1] = pas_id, > > > + .owner = ARM_SMCCC_OWNER_SIP, > > > + }; > > > + struct qcom_scm_res res; > > > + int ret; > > > + > > > + ret = qcom_scm_call(dev, &desc, &res); > > > + > > > + return ret ? : res.result[0]; > > > +} > > > + > > > +int qcom_scm_set_remote_state(u32 state, u32 id) > > > > s/id/pas_id > > Ack. > Coming back to this comment again, since this is a temporary wrapper which is going to be dropped as part of 2nd last patch, I don't think there is value to fix them as they maintain existing APIs interface. -Sumit