Re: [PATCH 07/10] dt-bindings: arm: qcomtee: add QTEE driver devicetree binding for TEE subsystem

[Krzysztof Kozlowski <krzk@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2472 bytes --]

On 03/12/2024 05:19, Amirreza Zarrabi wrote:
> Introduce qcom,tee compatible string.

Why? What is it for? You have entire commit msg for this, instead of
repeating subject.

A nit, subject: drop second/last, redundant "devicetree binding". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Also drop driver, bindings are not for drivers.

> 
> Signed-off-by: Amirreza Zarrabi <quic_azarrabi@quicinc.com>
> ---
>  .../devicetree/bindings/arm/firmware/qcom,tee.yaml | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/firmware/qcom,tee.yaml b/Documentation/devicetree/bindings/arm/firmware/qcom,tee.yaml
> new file mode 100644
> index 000000000000..43b7e8ac944e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/firmware/qcom,tee.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/firmware/qcom,tee.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm TEE
> +
> +maintainers:
> +  - Amirreza Zarrabi <quic_azarrabi@quicinc.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  QTEE is a piece of software provide a Trusted Execution Environment using ARM
> +  TrustZone for Qualcomm SoC.
> +
> +properties:
> +  $nodename:
> +    const: qcom_tee

No, first it is not correct (see coding style), second is not even
needed. Drop.

> +
> +  compatible:
> +    const: qcom,tee

One, same interface for all devices? Nothing SoC specific? You are
making now a contract, so please carefully analyze it internally what it
means.

> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    firmware {

Drop

> +        qcom_tee {

See DTS coding style.

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation


> +            compatible = "qcom,tee";

No resources? Nothing here? What is the point except of instantiating
your driver?

> +        };
> +    };
> 


Best regards,
Krzysztof