From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jan Koester <jan.koester@tuxist.de>, linux-kernel@vger.kernel.org
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jason Wang <jasowangio@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Karol Wachowski <karol.wachowski@linux.intel.com>,
Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>,
Oded Gabbay <ogabbay@kernel.org>,
Jens Wiklander <jenswi@kernel.org>,
Sumit Garg <sumit.garg@kernel.org>,
Christian Brauner <brauner@kernel.org>,
netdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
op-tee@lists.trustedfirmware.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/3] uid_r: convert tun, ivpu and tee
Date: Thu, 12 Nov 2026 19:05:15 -0500 [thread overview]
Message-ID: <willemdebruijn.kernel.31eb7df44411@gmail.com> (raw)
In-Reply-To: <20261112153841.1661720-1-jan.koester@tuxist.de>
Jan Koester wrote:
> Hi,
>
> Building the UUID/GUID id RFC (uid_r v2,
> <cover.1792552161.git.jan.koester@tuxist.de>) with a distribution
> config instead of the one I had tested with turned up three users of
> kuid_t/kgid_t it doesn't build with: kuid_t is a tagged union now and
> has no .val, and it no longer fits READ_ONCE()/WRITE_ONCE().
>
> 1/3 tun: TUNSETOWNER/TUNSETGROUP write the owner and group under RTNL,
> tun_fill_info() may read them without it. Mark that read as
> data_race() instead of READ_ONCE(). Only classic ids from
> make_kuid()/make_kgid() are ever stored there.
>
> 2/3 accel/ivpu: the per-user context limits are keyed by
> __kuid_val(). UUID and GUID users share the (uid_t)-1 bucket, which
> only makes the limit stricter for them.
>
> 3/3 tee: the TEE_IOCTL_LOGIN_USER client UUID is derived from the
> classic uid. With __kuid_val() alone every UUID or GUID user would
> get the same one and could act as any other such user towards the
> TEE, so those logins are refused with -EPERM, like ublk refuses
> unprivileged devices to them in the series.
>
> These belong into the series before the patch that lets kuid_t and
> kgid_t hold a UUID or a GUID and will be folded in there in v3; I'm sending
> them now so that the reviewers of these drivers see what uid_r means
> for them.
>
> Jan Koester (3):
> tun: read the owner and group without READ_ONCE()
> accel/ivpu: key user limits by __kuid_val()
> tee: refuse user logins of UUID and GUID users
>
> drivers/accel/ivpu/ivpu_drv.c | 2 +-
> drivers/net/tun.c | 8 ++++----
> drivers/tee/tee_core.c | 13 +++++++++++--
> 3 files changed, 16 insertions(+), 7 deletions(-)
I only received this cover letter. Also do not see the patches on
https://lore.kernel.org/all
prev parent reply other threads:[~2026-11-13 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1792552161.git.jan.koester@tuxist.de>
2026-11-12 15:38 ` [RFC PATCH v2 0/3] uid_r: convert tun, ivpu and tee Jan Koester via OP-TEE
2026-11-13 0:05 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.31eb7df44411@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrzej.kacprowski@linux.intel.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@kernel.org \
--cc=jan.koester@tuxist.de \
--cc=jasowangio@gmail.com \
--cc=jenswi@kernel.org \
--cc=karol.wachowski@linux.intel.com \
--cc=kuba@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=pabeni@redhat.com \
--cc=sumit.garg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox