Re: [PATCH 2/2] ARM: dts: aspeed: Add NVIDIA VR144NVL board

[Donald Shannon <donalds@nvidia.com>]

On 8/21/25 11:12, Conor Dooley wrote:

> On Wed, Aug 20, 2025 at 10:10:47PM -0700, Donald Shannon wrote:
>> +// I2C2
>> +// Baseboard 0 Management 1
>> +&i2c1 {
>> +	clock-frequency = <400000>;
>> +	status = "okay";
>> +
>> +	i2c-mux@70 {
>> +		compatible = "nxp,pca9548";
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +		reg = <0x70>;
>> +		i2c-mux-idle-disconnect;
>> +		vdd-supply = <&reg_3v3_stby>;
>> +
>> +		c0uphy0: i2c@0 {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +		reg = <0>;
> Incorrect indent.
>
>> +		};
>> +
>> +		c0uphy2: i2c@1 {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <1>;
>> +		};
>> +
>> +		c0unused2: i2c@2 {
> If these are unused, why are they here?
>
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <2>;
>> +		};
>> +
>> +		c0unused3: i2c@3 {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <3>;
>> +		};
>> +
>> +		c0unused4: i2c@4 {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <4>;
>> +		};
>> +
>> +		c0unused5: i2c@5 {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <5>;
>> +		};
>> +
>> +		c0unused6: i2c@6 {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <6>;
>> +		};
>> +
>> +		c0unused7: i2c@7 {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <7>;
>> +		};
>> +	};

Hi Connor,

I will remove those and we can add the busses back in for other platform variants' dts-es later if needed.

Thanks.