From: Dave Hansen <dave.hansen@intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: Borislav Petkov <bp@alien8.de>,
Guenter Roeck <linux@roeck-us.net>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Iwona Winiarska <iwona.winiarska@intel.com>,
linux-hwmon@vger.kernel.org, openbmc@lists.ozlabs.org,
Thomas Gleixner <tglx@kernel.org>,
Tony Luck <tony.luck@intel.com>,
x86@kernel.org
Subject: Re: [PATCH] [v2] peci: Remove dependency on x86 CPU variables
Date: Fri, 20 Feb 2026 10:20:14 -0800 [thread overview]
Message-ID: <13b9f03f-04e2-4363-af95-edded1c895c4@intel.com> (raw)
In-Reply-To: <b59da36c-4ddd-4cd9-98f2-b5a1db698889@intel.com>
On 2/20/26 10:14, Sohil Mehta wrote:
> On 2/20/2026 9:51 AM, Dave Hansen wrote:
>
>> * struct peci_device_id - PECI device data to match
>> * @data: pointer to driver private data specific to device
>> - * @x86_vfm: device vendor-family-model
>> + * @device_id: device identifier, includes CPU vendor-family-model
> Just a nit. There is an inconsistency between the two Kdoc comments.
>
> device_id no longer stores the vendor. The one below one is correct.
> CPUID.01H:EAX only gives the family-model-stepping information which is
> stored in the device_id after removing the stepping.
Very true. I'll change that for v3. I'll just be:
* @device_id: device identifier, includes CPU family-model
next prev parent reply other threads:[~2026-02-20 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 17:51 [PATCH] [v2] peci: Remove dependency on x86 CPU variables Dave Hansen
2026-02-20 18:00 ` Guenter Roeck
2026-02-20 18:14 ` Sohil Mehta
2026-02-20 18:20 ` Dave Hansen [this message]
2026-02-24 21:21 ` Winiarska, Iwona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13b9f03f-04e2-4363-af95-edded1c895c4@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=iwona.winiarska@intel.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=openbmc@lists.ozlabs.org \
--cc=sohil.mehta@intel.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox