Re: [PATCH linux dev-6.12 v1 1/6] soc: aspeed: Add XDMA Engine Driver

Andrew Jeffery
2025-09-03T02:14:42Z

On Tue, 2025-09-02 at 13:31 -0500, Ninad Palsule wrote:
> From: Eddie James <eajames@linux.ibm.com>
>
> The XDMA engine embedded in the AST2500 and AST2600 SOCs performs PCI
> DMA operations between the SOC (acting as a BMC) and a host processor
> in a server.
>
> This commit adds a driver to control the XDMA engine and adds functions
> to initialize the hardware and memory and start DMA operations.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> Link: https://lore.kernel.org/r/1588697905-23444-3-git-send-email-eajames@linux.ibm.com
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
> ---
>  MAINTAINERS                      |   2 +
>  drivers/soc/aspeed/Kconfig       |  10 +
>  drivers/soc/aspeed/Makefile      |   1 +
>  drivers/soc/aspeed/aspeed-xdma.c | 961 +++++++++++++++++++++++++++++++
>  include/uapi/linux/aspeed-xdma.h |  38 ++
>  5 files changed, 1012 insertions(+)
>  create mode 100644 drivers/soc/aspeed/aspeed-xdma.c
>  create mode 100644 include/uapi/linux/aspeed-xdma.h

Applying this to dev-6.12 and building it for aspeed_g5_defconfig
produces:

../drivers/soc/aspeed/aspeed-xdma.c: In function ‘aspeed_xdma_probe’:
../drivers/soc/aspeed/aspeed-xdma.c:844:1: warning: label ‘err_misc’ defined but not used [-Wunused-label]
844 | err_misc:
| ^~~~~~~~
../drivers/soc/aspeed/aspeed-xdma.c: In function ‘aspeed_xdma_remove’:
../drivers/soc/aspeed/aspeed-xdma.c:885:9: error: implicit declaration of function ‘misc_deregister’; did you mean ‘bus_unregister’? [-Werror=implicit-function-declaration]
885 | misc_deregister(&ctx->misc);
| ^~~~~~~~~~~~~~~
| bus_unregister
../drivers/soc/aspeed/aspeed-xdma.c:885:29: error: ‘struct aspeed_xdma’ has no member named ‘misc’
885 | misc_deregister(&ctx->misc);
| ^~
../drivers/soc/aspeed/aspeed-xdma.c: At top level:
../drivers/soc/aspeed/aspeed-xdma.c:423:12: warning: ‘aspeed_xdma_start’ defined but not used [-Wunused-function]
423 | static int aspeed_xdma_start(struct aspeed_xdma *ctx, unsigned int num_cmds,
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[6]: *** [../scripts/Makefile.build:229: drivers/soc/aspeed/aspeed-xdma.o] Error 1
make[5]: *** [../scripts/Makefile.build:478: drivers/soc/aspeed] Error 2
make[4]: *** [../scripts/Makefile.build:478: drivers/soc] Error 2
make[4]: *** Waiting for unfinished jobs....

Can you please fix these?

Also, during application, checkpatch complained:

✓ [PATCH v1 1/6] soc: aspeed: Add XDMA Engine Driver
+ Link: https://patch.msgid.link/20250902183155.2988560-2-ninad@linux.ibm.com
+ Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
● checkpatch.pl: 164: WARNING: please write a help paragraph that fully describes the config symbol
● checkpatch.pl: 228: WARNING: please, no space before tabs
● checkpatch.pl: 563: WARNING: quoted string split across lines
● checkpatch.pl: 834: WARNING: struct kobj_type should normally be const
● checkpatch.pl: 959: WARNING: Possible unnecessary 'out of memory' message
● checkpatch.pl: 1152: WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")

Can you please address these as well when posting v2?

Thanks,

Andrew