Re: [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a new YAML

Krzysztof Kozlowski
2025-10-24T12:43:41Z

On 24/10/2025 14:36, Ryan Chen wrote:
>> Subject: Re: [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a new
>> YAML
>>
>> Hi Kyzysztof,
>>
>>>> Not much different than every other soc. All of them are separate
>>>> IPs.
>>>> Look at any Samsung, NXP or Qualcomm binding. Separate IPs.
>>>
>>>
>>> So let the move happen, but please explain in the commit msg that
>>> devices are completely different - nothing in common - and thus the
>>> binding will be different. We indeed do not keep completely different
>>> devices in one binding, but based on commit msg I had impression this
>>> was just major block upgrade.
>>
>> OK, makes sense.
>>
>> Ryan, let me know if you need a hand with the commit message changes.
>>
> Thanks Jeremy and Krzysztof,
>
> If I modify the commit message as follows, would that make it clearer?
>
> The AST2600 I2C controller introduces a completely new register map and
> Separate control/target register sets, unlike the mixed layout used in
> AST2400/AST2500. In addition, at new AST2600 configuration registers
> and transfer modes require new DT properties, which are incompatible
> with existing bindings. Therefore, this patch creates a dedicated binding
> file for AST2600 to properly describe these new hardware capabilities.

It's fine.

Best regards,
Krzysztof