Re: [PATCH] peci: Remove dependency on x86 CPU variables

Sohil Mehta
2026-02-18T23:06:23Z

On 2/18/2026 11:36 AM, Sohil Mehta wrote:
> On 2/18/2026 11:30 AM, Dave Hansen wrote:
>
>>>> +#define PECI_INTEL_HASWELL_X 0x306C
>>>> +#define PECI_INTEL_BROADWELL_X 0x406F
>>>> +#define PECI_INTEL_BROADWELL_D 0x5066
>>>> +#define PECI_INTEL_SKYLAKE_X 0x5065
>>>> +#define PECI_INTEL_ICELAKE_X 0x606A
>>>> +#define PECI_INTEL_ICELAKE_D 0x606C
>>>> +#define PECI_INTEL_SAPPHIRERAPIDS_X 0x806F
>>>> +#define PECI_INTEL_EMERALDRAPIDS_X 0xC06F
>>>>
>>>
>>> The _D has been used in Intel official product names such as "XEON D".
>>> AFAIU, The _X notation is specific to intel-family.h. Should that be
>>> explained in the comment above?
>>>
>>> Something like:
>>>
>>> * _X - regular server parts
>>> * _D - micro server parts
>>
>> I think I just verbatim copied the intel-family.h names and added PECI_.
>> Are you seeing something different.
>>
>
> No.
>

Scratch that. I see a difference.

#define INTEL_HASWELL IFM(6, 0x3C)
#define INTEL_HASWELL_X IFM(6, 0x3F)

PECI_INTEL_HASWELL_X (0x306C) doesn't match INTEL_HASWELL_X instead you
seem to have copied INTEL_HASWELL.