Re: [PATCH] peci: Remove dependency on x86 CPU variables

Dave Hansen
2026-02-19T14:58:15Z

On 2/19/26 02:20, David Laight wrote:
>> tl;dr: The non-x86 PECI driver #includes an arch/x86 header. This is
>> ostensibly to avoid duplicating CPU model number constants, but the
>> result is complexity and duplicated *code* which is a far worse fate
>> than duplicated constants.
> Is is possible/sensible to add a check in one file that includes both
> headers that the constants match?
>
> That will help pick up any typos.

I don't think it's worth it. Honestly, the _only_ reason to share names
is to avoid doubling the inevitable name bikeshedding that happens every
time we try to name a CPU model.

I honestly don't think it matters if the names diverge otherwise.