Re: [PATCH] [v2] peci: Remove dependency on x86 CPU variables

Dave Hansen
2026-02-20T18:21:29Z

On 2/20/26 10:14, Sohil Mehta wrote:
> On 2/20/2026 9:51 AM, Dave Hansen wrote:
>
>> * struct peci_device_id - PECI device data to match
>> * @data: pointer to driver private data specific to device
>> - * @x86_vfm: device vendor-family-model
>> + * @device_id: device identifier, includes CPU vendor-family-model
> Just a nit. There is an inconsistency between the two Kdoc comments.
>
> device_id no longer stores the vendor. The one below one is correct.
> CPUID.01H:EAX only gives the family-model-stepping information which is
> stored in the device_id after removing the stepping.

Very true. I'll change that for v3. I'll just be:

* @device_id: device identifier, includes CPU family-model