Re: [PATCH] [v2] peci: Remove dependency on x86 CPU variables

Sohil Mehta
2026-02-22T23:06:37Z

On 2/20/2026 9:51 AM, Dave Hansen wrote:

> * struct peci_device_id - PECI device data to match
> * @data: pointer to driver private data specific to device
> - * @x86_vfm: device vendor-family-model
> + * @device_id: device identifier, includes CPU vendor-family-model

Just a nit. There is an inconsistency between the two Kdoc comments.

device_id no longer stores the vendor. The one below one is correct.
CPUID.01H:EAX only gives the family-model-stepping information which is
stored in the device_id after removing the stepping.

> * struct peci_device - PECI device
> * @dev: device object to register PECI device to the device model
> * @info: PECI device characteristics
> - * @info.x86_vfm: device vendor-family-model
> + * @info.device_id: device identifier (CPU family-model)