Re: [PATCH v5 15/17] spi: uniphier: Simplify clock handling with devm_clk_get_enabled()

Mark Brown
2026-03-23T21:49:45Z

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

On Thu, Mar 19, 2026 at 10:04:11AM +0800, Pei Xiao wrote:
> Replace devm_clk_get() followed by clk_prepare_enable() with
> devm_clk_get_enabled() for the clock. This removes the need for
> explicit clock enable and disable calls, as the managed API automatically
> handles clock disabling on device removal or probe failure.

This breaks an allmodconfig build:

/build/stage/linux/drivers/spi/spi-uniphier.c: In function ‘uniphier_spi_remove’
:
/build/stage/linux/drivers/spi/spi-uniphier.c:773:35: error: unused variable ‘pr
iv’ [-Werror=unused-variable]
773 | struct uniphier_spi_priv *priv = spi_controller_get_devdata(host
);
| ^~~~

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]