From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C71C8C5518F for ; Tue, 4 Aug 2026 07:56:11 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4hDm7m0RFJz2yYs; Tue, 04 Aug 2026 17:56:04 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1785830163; cv=none; b=bAI/lb6kE7FOELb/k6C9/iHWyMHT5+8yL6Q7oCmPIqcP51FPdo0l+NIyPFuwrSwzTWoRtcBI97PbQcQz+Mo713N+veuo/35Uh5JzFf18oSxcLchHBdYmHxMX3XPXMtrdf1HVf2ilK9vUNyiOzETGVUNwBVYiyDtziYo5yOWl5YSXjMg87+IUqVN2xDXPbyj4OzXxAO6VrTaiPfYXCn35hg+5i6uyIk8KuUC86N81mADbWgH8kfHTPQ720gB5RwPr7AMRP1WOagbYObnYxOtcQYRV9hgFl7jpEVXioxHt9nXOsSfLU8ec0PxI1YU0xBdfNa5SdzvqRHxMGeU8/IOBfQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1785830163; c=relaxed/relaxed; bh=yeDxhag+TNNWASBx4n6SWled1gX7BxGiMg6M2Cvsz6s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KKM1zxCewVBd9AnQQkxxlBnULL66FOBWq+iHYa3dpqfcTab+hXTqSsGWRmaDj1hoqj03gSJdpzWnC0ZadUUVhkcw16BQV+u8+YJ5auZdwT2b+Bvovh42PayCvMd5HUDadv+jUenrmWlxPSN8HBbRGwlg2/zX6uPNne0c3igXhjp/LyemazXmRVpLZTf+jSbiUtjn0HuP9mkFVsiDw3dx0JjBPNEfhEbV2g11ONxMVnBhzEkBva0ei/kxOrTLf1Lx71PdxuXKlrcXuyXTvTjqE/wtMTni5zfZ4c1zjmjMpbbMEeVG17z7l6zL9QY5OGxhL58aojutq3PM1jW1HCu50Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LoJHrsID; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=krzk@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LoJHrsID; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=krzk@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4hDm7k5FGHz2xyk for ; Tue, 04 Aug 2026 17:56:02 +1000 (AEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id CB31E60A77; Tue, 4 Aug 2026 07:55:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8645D1F00A3A; Tue, 4 Aug 2026 07:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785830159; bh=yeDxhag+TNNWASBx4n6SWled1gX7BxGiMg6M2Cvsz6s=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LoJHrsID+TjLQwZyWHc6+v6F2Ih8Ys5ua5zUJ2D2M7Eml+bb1vCC0wqf1HKhf4Jd/ UWVRIf4n5chatnzsc4UesIRilitp/fYTiU8pINVwQl9G4qj61V6su7xetQIS3xL5RF dS98ithodVC+XexFBZpPsjc4f8TeiiuK6t85jC27SGfq19KhIfJN1sD1+4mAAMaMyL LNAaRqTnXVzUBkHYzytkm4rZUb1qg1Fttc6gPdc48K76vHjq1jHX7nF/tdMsOzSTMW yatQvjwnJJ6Ns49pNqy7TT/XNXjcWYeruYisHUV6/eM7DM76uvqcZawfBeSe/QAhC3 X3raOFkE2IC2Q== Date: Tue, 4 Aug 2026 09:55:55 +0200 From: Krzysztof Kozlowski To: Tzu-Hao Wei Cc: Shubhangini G , Prasad Bolisetty , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Karthikeyan Mitran , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH 1/2] dt-bindings: media: add axiado,ax3000-video Message-ID: <20260804-healthy-versatile-barnacle-b58db9@quoll> References: <20260730-ax3000-display-driver-v1-0-4fbd4d0c85d3@axiado.com> <20260730-ax3000-display-driver-v1-1-4fbd4d0c85d3@axiado.com> <9f689436-04c6-48d6-8342-7fac998f3910@kernel.org> X-Mailing-List: openbmc@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Tue, Aug 04, 2026 at 07:31:25AM +0800, Tzu-Hao Wei wrote: > >> There is no local register interface for this driver to program: frame > >> delivery is controlled entirely by the host-side display engine and > >> the PCIe endpoint mapping that feeds the shared region, both external > >> to this driver. A software polling timer schedules a workqueue item at > >> the configured framerate, which copies frames from the WC-mapped > >> shared region into vmalloc-backed vb2 buffers. Running the copy in a > >> work item rather than directly in the timer callback keeps potentially > >> multi-megabyte memcpy and per-pixel conversion work out of softirq > >> context. > > > > Then this is not a separate device. You just described a Linux driver. > > > > I still wait for answers of my question above. You described getting > > buffers only. > > > > Thank you for the continued review. > > To correctly represent this in device tree without describing a > software driver as a hardware device, would moving the schema into > /reserved-memory be the preferred approach for v2? > > Specifically, we are considering moving it to: > Documentation/devicetree/bindings/reserved-memory/axiado,ax3000-video-mem.yaml I would rather suggest this should be part of the device handling the host side of the device. Or is there none? Again, how do you configure the frame parameters or start capturing the data? > > This would follow the same Devicetree architectural pattern as > qcom,rmtfs-mem: > Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml > > Just as qcom,rmtfs-mem describes a reserved memory buffer used by > remote processors and exports /dev/rmtfs_mem%d without hardware MMIO > registers, clocks, or resets, axiado,ax3000-video describes the > reserved memory buffer used by the AX3000 display pipeline and exports > /dev/video0. > > Does representing axiado,ax3000-video as a reserved-memory node look > like the appropriate way to model this in v2? So from a device we went now to pure memory... That's quite a change and would prove this was completely bogus hardware description. I actually fail to see any hardware here, because you could just allocate whatever memory and pass it to your host, no? Why it has to be a reserved memory? Best regards, Krzysztof