From: Cosmo Chou <chou.cosmo@gmail.com>
To: andrew@codeconstruct.com.au, openbmc@lists.ozlabs.org
Cc: chou.cosmo@gmail.com, cosmo.chou@quantatw.com,
Billy Tsai <billy_tsai@aspeedtech.com>
Subject: [PATCH linux dev-6.18 1/4] iio: adc: Add battery channel definition for ADC
Date: Wed, 5 Aug 2026 14:13:06 +0800 [thread overview]
Message-ID: <20260805061310.1740724-2-chou.cosmo@gmail.com> (raw)
In-Reply-To: <20260805061310.1740724-1-chou.cosmo@gmail.com>
From: Billy Tsai <billy_tsai@aspeedtech.com>
Defines a constant for the battery sensing channel, typically the last
channel of the ADC. Clarifies channel usage and improves code
readability.
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/iio/adc/aspeed_adc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
index 4be44c524b4d..8eebaa3dc534 100644
--- a/drivers/iio/adc/aspeed_adc.c
+++ b/drivers/iio/adc/aspeed_adc.c
@@ -75,6 +75,8 @@
#define ASPEED_ADC_INIT_POLLING_TIME 500
#define ASPEED_ADC_INIT_TIMEOUT 500000
+/* Battery sensing is typically on the last channel */
+#define ASPEED_ADC_BATTERY_CHANNEL 7
/*
* When the sampling rate is too high, the ADC may not have enough charging
* time, resulting in a low voltage value. Thus, the default uses a slow
@@ -285,7 +287,7 @@ static int aspeed_adc_read_raw(struct iio_dev *indio_dev,
switch (mask) {
case IIO_CHAN_INFO_RAW:
- if (data->battery_sensing && chan->channel == 7) {
+ if (data->battery_sensing && chan->channel == ASPEED_ADC_BATTERY_CHANNEL) {
adc_engine_control_reg_val =
readl(data->base + ASPEED_REG_ENGINE_CONTROL);
writel(adc_engine_control_reg_val |
@@ -309,7 +311,7 @@ static int aspeed_adc_read_raw(struct iio_dev *indio_dev,
return IIO_VAL_INT;
case IIO_CHAN_INFO_OFFSET:
- if (data->battery_sensing && chan->channel == 7)
+ if (data->battery_sensing && chan->channel == ASPEED_ADC_BATTERY_CHANNEL)
*val = (data->cv * data->battery_mode_gain.mult) /
data->battery_mode_gain.div;
else
--
2.53.0
next prev parent reply other threads:[~2026-08-05 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 6:13 [PATCH linux dev-6.18 0/4] iio: adc: aspeed: Backport battery sensing patches Cosmo Chou
2026-08-05 6:13 ` Cosmo Chou [this message]
2026-08-05 6:13 ` [PATCH linux dev-6.18 2/4] iio: adc: Enable multiple consecutive channels based on model data Cosmo Chou
2026-08-05 6:13 ` [PATCH linux dev-6.18 3/4] iio: adc: aspeed: Replace mdelay() with fsleep() for ADC stabilization delay Cosmo Chou
2026-08-05 6:13 ` [PATCH linux dev-6.18 4/4] iio: adc: aspeed: Reserve battery sensing channel for on-demand use Cosmo Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805061310.1740724-2-chou.cosmo@gmail.com \
--to=chou.cosmo@gmail.com \
--cc=andrew@codeconstruct.com.au \
--cc=billy_tsai@aspeedtech.com \
--cc=cosmo.chou@quantatw.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox