Re: [PATCH u-boot 1/2] Add a new board for the gigabyte msx4

[Andrew Jeffery <andrew@codeconstruct.com.au>]

On Tue, 2025-11-25 at 17:30 -0800, Marc Olberding wrote:
> On Wed, Nov 26, 2025 at 11:00:33AM +1030, Andrew Jeffery wrote:
> > On Fri, 2025-11-21 at 16:02 -0800, Marc Olberding wrote:
> > > +}
> > 
> > Can we rather add support to the SPI driver, and disable it via a
> > devicetree property?
> > 
> > That way the option is available to other platforms and minimises the
> > spread of board file code.
> 
> I think that's reasonable, and I can put up a patchset for that.
> 
> are you okay with something like:
> ```
> &fmc {
> 	status = "okay";
> 	fmc-wdt2-disable;
> ....
> };
> ```
> 
> as the target config? or potentially drop the extra fmc...

It would be best to prefix it. What do you think of `aspeed,disable-
watchdog`?

> 
> For what its worth, WDT2 is actually disabled in the platform.S for the 2600
> but its disabled by an #if 0 preproc directive. I think dealing with this in the driver
> is a good idea and relatively low lift. In the response to the cover letter I had asked
> for any ideas without reading this email :). I'll get this patch set up, thanks for the
> feedback. 
> > 
> > What is the behavioural difference to what's in
> > board/aspeed/ast2600_intel/intel.c? It's a little annoying to tell
> > because intel.c uses macro symbols for the register offsets where
> > you've open-coded the values here.
> > 
> > Can we try to make the implementation common?
> > 
> > Andrew
> 
> It's functionally the same, and to be honest this code is proliferated across
> at least 3 board files. I can certainly make a helper function,
> but I don't have access to test all of the boards. If you're happy with
> it being "correct by inspection that it does the same thing" and "it builds",
> I can move these board files over to using the common helper.

Let's get the code centralised, make the MSX4 using that centralised
code, and then follow with patches converting the other platforms. Make
sure to CC maintainers of the other affected platforms where you can,
and if things are okay by inspection and no-one screams, I'll apply
them all. Otherwise we can just apply the first couple and quibble over
what we do about the other platforms in slow-time.

Andrew