public inbox for openbmc@ozlabs.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon	 <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture	 <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH] arm64: dts: nuvoton: Add missing "device_type" property on memory node
Date: Thu, 08 Jan 2026 17:39:19 +1030	[thread overview]
Message-ID: <7e20473324c8da16fa86f72af950b8e8eac92a1b.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260105193232.3167128-1-robh@kernel.org>

On Mon, 2026-01-05 at 13:32 -0600, Rob Herring (Arm) wrote:
> "device_type" is required for memory nodes, but is missing on Nuvoton
> npcm845-evb.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> index 2638ee1c3846..5edf5d13342d 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> @@ -17,6 +17,7 @@ chosen {
>  	};
>  
>  	memory@0 {
> +		device_type = "memory";
>  		reg = <0x0 0x0 0x0 0x40000000>;
>  	};
>  

Hmm, we have quite a few other offenders under arch/arm/boot/dts/aspeed
too. I expect this should be caught by CHECK_DTBS=y?

Digging back through my build archives, warnings have cropped up, but
only for when I'm building the arm64 or arm multi_v{5,7} defconfigsm
and seemingly not the aspeed_g5 defconfig.

executions/2024Y/2024Y08m/2024Y08m13d10H09M/20240812145816.3301570-1-tmaimon77@gmail.com.md:      /home/andrew/src/kernel.org/linux/openbmc/build.npcm/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: /: memory: 'device_type' is a required property
executions/2025Y/2025Y04m/2025Y04m03d21H04M/baseline-build:/home/andrew/src/kernel.org/linux/origin/build.multi_v5/arch/arm/boot/dts/nuvoton/nuvoton-npcm750-evb.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 536870912]]}
executions/2025Y/2025Y04m/2025Y04m04d00H57M/baseline-build:/home/andrew/src/kernel.org/linux/origin/build.multi_v5/arch/arm/boot/dts/nuvoton/nuvoton-npcm750-evb.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 536870912]]}
executions/2025Y/2025Y04m/2025Y04m04d01H10M/baseline-build:/home/andrew/src/kernel.org/linux/origin/build.multi_v5/arch/arm/boot/dts/nuvoton/nuvoton-npcm750-evb.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 536870912]]}
executions/2025Y/2025Y04m/2025Y04m08d10H18M/baseline-build:/home/andrew/src/kernel.org/linux/origin/build.multi_v7/arch/arm/boot/dts/nuvoton/nuvoton-npcm750-evb.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 536870912]]}
executions/2025Y/2025Y05m/2025Y05m07d11H43M/03-diff-ref-curr: /home/andrew/src/kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: /: memory@0: 'device_type' is a required property
executions/2025Y/2025Y05m/2025Y05m07d11H43M/baseline-build:/home/andrew/src/kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: /: memory@0: 'device_type' is a required property
executions/2025Y/2025Y06m/2025Y06m13d11H17M/03-diff-ref-curr: /home/andrew/src/kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: / (nuvoton,npcm845-evb): memory@0: 'device_type' is a required property
executions/2025Y/2025Y06m/2025Y06m13d11H17M/baseline-build:/home/andrew/src/kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: / (nuvoton,npcm845-evb): memory@0: 'device_type' is a required property
executions/2025Y/2025Y07m/2025Y07m21d10H53M/baseline-build:/home/andrew/src/kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: / (nuvoton,npcm845-evb): memory@0: 'device_type' is a required property
executions/2025Y/2025Y07m/2025Y07m21d10H53M/make-dtbs-check: /home/andrew/src/kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: / (nuvoton,npcm845-evb): memory@0: 'device_type' is a required property
executions/2025Y/2025Y07m/2025Y07m21d12H20M/baseline-build:/home/andrew/src/kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: / (nuvoton,npcm845-evb): memory@0: 'device_type' is a required property
executions/2025Y/2025Y07m/2025Y07m21d12H20M/make-dtbs-check: /home/andrew/src/kernel.org/linux/origin/build.arm64.default/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: / (nuvoton,npcm845-evb): memory@0: 'device_type' is a required property
executions/2025Y/2025Y07m/2025Y07m21d13H58M/baseline-build:/home/andrew/src/kernel.org/linux/origin/build.arm.multi_v7/arch/arm/boot/dts/nuvoton/nuvoton-npcm750-evb.dtb: / (nuvoton,npcm750-evb): memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 536870912]]}

I don't yet understand why that is, but I'll do some digging. I expect
there will be some fixes to send once I figure it out.

Andrew


  reply	other threads:[~2026-01-08  7:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05 19:32 [PATCH] arm64: dts: nuvoton: Add missing "device_type" property on memory node Rob Herring (Arm)
2026-01-08  7:09 ` Andrew Jeffery [this message]
2026-01-08  8:58   ` Andrew Jeffery
2026-01-08 15:02   ` Rob Herring
2026-01-08  9:28 ` Andrew Jeffery
2026-01-08 14:56   ` Rob Herring
2026-01-09  1:09     ` Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e20473324c8da16fa86f72af950b8e8eac92a1b.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=tmaimon77@gmail.com \
    --cc=venture@google.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox