From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: robh@kernel.org, conor+dt@kernel.org,
andriy.shevchenko@linux.intel.com, andi.shyti@kernel.org,
linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
joel@jms.id.au, p.zabel@pengutronix.de, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v16 1/3] dt-bindings: i2c: aspeed: support for AST2600-i2cv2
Date: Mon, 24 Feb 2025 10:12:51 +0100 [thread overview]
Message-ID: <972b2116-3343-49a6-9304-ed22eb909eaa@kernel.org> (raw)
In-Reply-To: <20250224-arrogant-adventurous-mackerel-0dc18a@krzk-bin>
On 24/02/2025 10:11, Krzysztof Kozlowski wrote:
>
>
>> +
>> required:
>> - reg
>> - compatible
>> - clocks
>> - resets
>>
>> +allOf:
>> + - $ref: /schemas/i2c/i2c-controller.yaml#
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: aspeed,ast2600-i2cv2
>
> NAK, undocumented compatible.
Heh, and this was in previous versions as well.
You have never tested your DTS. At v16 still no testing. This is not
acceptable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-24 9:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 5:59 [PATCH v16 0/3] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2025-02-24 5:59 ` [PATCH v16 1/3] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Ryan Chen
2025-02-24 7:16 ` Rob Herring (Arm)
2025-02-24 9:11 ` Krzysztof Kozlowski
2025-02-24 9:12 ` Krzysztof Kozlowski [this message]
2025-02-26 9:28 ` Ryan Chen
2025-02-26 9:56 ` Krzysztof Kozlowski
2025-02-27 8:19 ` Ryan Chen
2025-02-27 20:04 ` Krzysztof Kozlowski
2025-03-05 9:35 ` Ryan Chen
2025-03-17 7:45 ` Krzysztof Kozlowski
2025-03-17 9:21 ` Ryan Chen
2025-03-19 7:44 ` Krzysztof Kozlowski
2025-03-19 11:12 ` Ryan Chen
2025-03-24 7:21 ` Krzysztof Kozlowski
2025-03-24 8:30 ` Ryan Chen
2025-03-24 9:07 ` Krzysztof Kozlowski
2025-03-24 10:01 ` Ryan Chen
2025-03-24 11:10 ` Krzysztof Kozlowski
2025-03-25 9:52 ` Ryan Chen
2025-03-25 10:18 ` Krzysztof Kozlowski
2025-09-10 7:25 ` Jeremy Kerr
2025-09-10 7:44 ` Krzysztof Kozlowski
2025-09-10 8:31 ` Jeremy Kerr
2025-09-11 1:27 ` Ryan Chen
2025-09-11 1:38 ` Jeremy Kerr
2025-09-11 9:03 ` Jeremy Kerr
2025-09-12 6:37 ` Krzysztof Kozlowski
2025-09-12 7:13 ` Ryan Chen
2025-02-24 5:59 ` [PATCH v16 2/3] i2c: aspeed: support AST2600 i2c new register mode driver Ryan Chen
2025-02-24 8:54 ` Philipp Zabel
2025-02-24 9:04 ` Ryan Chen
2025-02-24 9:32 ` Philipp Zabel
2025-02-28 1:28 ` kernel test robot
2025-02-28 12:38 ` Andy Shevchenko
2025-03-17 7:48 ` Krzysztof Kozlowski
2025-03-17 8:00 ` Andy Shevchenko
2025-03-17 8:51 ` Ryan Chen
2025-03-17 8:57 ` Krzysztof Kozlowski
2025-02-24 5:59 ` [PATCH v16 3/3] i2c: aspeed: support AST2600 i2c new register target " Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=972b2116-3343-49a6-9304-ed22eb909eaa@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox