Re: On Code Reviews...

Andrew Jeffery
2025-09-22T00:01:53Z

On Sat, 2025-09-20 at 23:10 -0400, Patrick Williams wrote:
>
>
> # Data on commits
>
> I have another tool which can collect the current state of code reviews
> (more on this later).  This is a report of where we are currently at:
>
> ╭───────────┬───────────┬─────────────┬────────╮
> │           ┆ Community ┆ Maintainers ┆ Author │
> ╞═══════════╪═══════════╪═════════════╪════════╡
> │ <24 hours ┆ 3         ┆ 1           ┆ 2      │
> ├╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌┤
> │ <72 hours ┆ 64        ┆ 15          ┆ 66     │
> ├╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌┤
> │ <2 weeks  ┆ 73        ┆ 24          ┆ 92     │
> ├╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌┤
> │ <8 weeks  ┆ 43        ┆ 38          ┆ 132    │
> ├╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌┤
> │ >8 weeks  ┆ 97        ┆ 34          ┆ 588    │
> ╰───────────┴───────────┴─────────────┴────────╯
>
> Legend:
>     * "Author" - There is something wrong with this commit that needs to
>                  be addressed by the author.
>     * "Community" - There has not been any review of this commit; the
>                     expectation is that we have _someone_ other than the
>                     maintainer do an initial review.
>     * "Maintainer" - The commit is "good to go" and has at least one
>                      review.  It is now waiting for final review and
>                      [hopefully] merge.

A bit of a divergence into personal preference, but can we order the
columns in terms of patch progression into the the repo? So Author,
Community, Maintainers?

>
> In Discord you'll see a new "openbmc-bot".  This bot also serves a website
> at https://openbmc.stwcx.xyz/bot .  Feel free to pause and go there now.

It'd be mildly interesting to allow sorting by e.g. total outstanding
patches, or specific patch states.

Andrew