public inbox for openbmc@ozlabs.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
@ 2026-03-01  4:00 Anirudh Srinivasan
  2026-03-01  4:10 ` Anirudh Srinivasan
  2026-03-05  5:22 ` Andrew Jeffery
  0 siblings, 2 replies; 9+ messages in thread
From: Anirudh Srinivasan @ 2026-03-01  4:00 UTC (permalink / raw)
  To: joel, andrew; +Cc: openbmc, Anirudh Srinivasan

Add dts for Asus Kommando IPMI card, an ast2600 based pcie bmc card

Signed-off-by: Anirudh Srinivasan <anirudhsriniv@gmail.com>
---
 arch/arm/dts/Makefile                            |  1 +
 arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts | 98 ++++++++++++++++++++++++
 2 files changed, 99 insertions(+)

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 5141c3dc3aa025e2f5c9b2bb98216ee5c72cdf70..fa6837be747da4fbe102ac27e60ee3d81e230cb7 100755
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -682,6 +682,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	ast2500-genesis3.dtb \
 	ast2500-romulus.dtb \
 	ast2600-ampere.dtb \
+	ast2600-asus-kommando-ipmi-card.dtb \
 	ast2600-bletchley.dtb \
 	ast2600-dcscm.dtb \
 	ast2600-evb-ecc.dtb \
diff --git a/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts b/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts
new file mode 100644
index 0000000000000000000000000000000000000000..11fee8d5403541f2453f6b8c6f123c5d1108137d
--- /dev/null
+++ b/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts
@@ -0,0 +1,98 @@
+// SPDX-License-Identifier: GPL-2.0+
+/dts-v1/;
+
+#include "ast2600-u-boot.dtsi"
+
+/ {
+	model = "ASUS Kommando IPMI Card";
+	compatible = "asus,kommando-ipmi-card", "aspeed,ast2600";
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x40000000>;
+	};
+
+	chosen {
+		stdout-path = &uart5;
+	};
+
+	aliases {
+		spi0 = &fmc;
+		ethernet0 = &mac2;
+	};
+
+	cpus {
+		cpu@0 {
+			clock-frequency = <800000000>;
+		};
+		cpu@1 {
+			clock-frequency = <800000000>;
+		};
+	};
+};
+
+&fmc {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fmcquad_default>;
+
+	flash@0 {
+		status = "okay";
+		spi-max-frequency = <50000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+	};
+};
+
+&hace {
+	status = "okay";
+	u-boot,dm-pre-reloc;
+};
+
+&mac2 {
+	status = "okay";
+	phy-mode = "rgmii";
+	phy-handle = <&ethphy2>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii3_default>;
+};
+
+&mdio {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_mdio3_default>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	ethphy2: ethernet-phy@2 {
+		reg = <0>;
+	};
+};
+
+&scu {
+	mac2-clk-delay = <0x08 0x04
+			  0x08 0x04
+			  0x08 0x04>;
+};
+
+&sdrammc {
+	clock-frequency = <400000000>;
+};
+
+&uart5 {
+	status = "okay";
+	u-boot,dm-pre-reloc;
+};
+
+&wdt1 {
+	status = "okay";
+};
+
+&wdt2 {
+	status = "okay";
+};
+
+&wdt3 {
+	status = "okay";
+};

---
base-commit: d40130c7056b84dc5213f3ff6764d0e45bb84035
change-id: 20260228-asus-kommando-9de4d6b779a8

Best regards,
-- 
Anirudh Srinivasan <anirudhsriniv@gmail.com>



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
  2026-03-01  4:00 [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card Anirudh Srinivasan
@ 2026-03-01  4:10 ` Anirudh Srinivasan
  2026-03-02  0:35   ` Andrew Jeffery
  2026-03-05  5:22 ` Andrew Jeffery
  1 sibling, 1 reply; 9+ messages in thread
From: Anirudh Srinivasan @ 2026-03-01  4:10 UTC (permalink / raw)
  To: joel, andrew; +Cc: openbmc

Apologies, This patch was meant for the u-boot tree and I forgot to
include u-boot as a prefix in the patch title.

Should I resend another version with the corrected title?

On Sat, Feb 28, 2026 at 10:00 PM Anirudh Srinivasan
<anirudhsriniv@gmail.com> wrote:
>
> Add dts for Asus Kommando IPMI card, an ast2600 based pcie bmc card
>
> Signed-off-by: Anirudh Srinivasan <anirudhsriniv@gmail.com>
> ---
>  arch/arm/dts/Makefile                            |  1 +
>  arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts | 98 ++++++++++++++++++++++++
>  2 files changed, 99 insertions(+)
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 5141c3dc3aa025e2f5c9b2bb98216ee5c72cdf70..fa6837be747da4fbe102ac27e60ee3d81e230cb7 100755
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -682,6 +682,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>         ast2500-genesis3.dtb \
>         ast2500-romulus.dtb \
>         ast2600-ampere.dtb \
> +       ast2600-asus-kommando-ipmi-card.dtb \
>         ast2600-bletchley.dtb \
>         ast2600-dcscm.dtb \
>         ast2600-evb-ecc.dtb \
> diff --git a/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts b/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts
> new file mode 100644
> index 0000000000000000000000000000000000000000..11fee8d5403541f2453f6b8c6f123c5d1108137d
> --- /dev/null
> +++ b/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts
> @@ -0,0 +1,98 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/dts-v1/;
> +
> +#include "ast2600-u-boot.dtsi"
> +
> +/ {
> +       model = "ASUS Kommando IPMI Card";
> +       compatible = "asus,kommando-ipmi-card", "aspeed,ast2600";
> +
> +       memory {
> +               device_type = "memory";
> +               reg = <0x80000000 0x40000000>;
> +       };
> +
> +       chosen {
> +               stdout-path = &uart5;
> +       };
> +
> +       aliases {
> +               spi0 = &fmc;
> +               ethernet0 = &mac2;
> +       };
> +
> +       cpus {
> +               cpu@0 {
> +                       clock-frequency = <800000000>;
> +               };
> +               cpu@1 {
> +                       clock-frequency = <800000000>;
> +               };
> +       };
> +};
> +
> +&fmc {
> +       status = "okay";
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_fmcquad_default>;
> +
> +       flash@0 {
> +               status = "okay";
> +               spi-max-frequency = <50000000>;
> +               spi-tx-bus-width = <4>;
> +               spi-rx-bus-width = <4>;
> +       };
> +};
> +
> +&hace {
> +       status = "okay";
> +       u-boot,dm-pre-reloc;
> +};
> +
> +&mac2 {
> +       status = "okay";
> +       phy-mode = "rgmii";
> +       phy-handle = <&ethphy2>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rgmii3_default>;
> +};
> +
> +&mdio {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_mdio3_default>;
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +
> +       ethphy2: ethernet-phy@2 {
> +               reg = <0>;
> +       };
> +};
> +
> +&scu {
> +       mac2-clk-delay = <0x08 0x04
> +                         0x08 0x04
> +                         0x08 0x04>;
> +};
> +
> +&sdrammc {
> +       clock-frequency = <400000000>;
> +};
> +
> +&uart5 {
> +       status = "okay";
> +       u-boot,dm-pre-reloc;
> +};
> +
> +&wdt1 {
> +       status = "okay";
> +};
> +
> +&wdt2 {
> +       status = "okay";
> +};
> +
> +&wdt3 {
> +       status = "okay";
> +};
>
> ---
> base-commit: d40130c7056b84dc5213f3ff6764d0e45bb84035
> change-id: 20260228-asus-kommando-9de4d6b779a8
>
> Best regards,
> --
> Anirudh Srinivasan <anirudhsriniv@gmail.com>
>


-- 
Regards
Anirudh Srinivasan


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
  2026-03-01  4:10 ` Anirudh Srinivasan
@ 2026-03-02  0:35   ` Andrew Jeffery
  0 siblings, 0 replies; 9+ messages in thread
From: Andrew Jeffery @ 2026-03-02  0:35 UTC (permalink / raw)
  To: Anirudh Srinivasan, joel; +Cc: openbmc

On Sat, 2026-02-28 at 22:10 -0600, Anirudh Srinivasan wrote:
> Apologies, This patch was meant for the u-boot tree and I forgot to
> include u-boot as a prefix in the patch title.
> 
> Should I resend another version with the corrected title?

No, this reply is enough, thanks :)

Andrew


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
  2026-03-01  4:00 [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card Anirudh Srinivasan
  2026-03-01  4:10 ` Anirudh Srinivasan
@ 2026-03-05  5:22 ` Andrew Jeffery
  2026-03-06  0:32   ` Anirudh Srinivasan
  1 sibling, 1 reply; 9+ messages in thread
From: Andrew Jeffery @ 2026-03-05  5:22 UTC (permalink / raw)
  To: Anirudh Srinivasan, joel; +Cc: openbmc

On Sat, 2026-02-28 at 22:00 -0600, Anirudh Srinivasan wrote:
> Add dts for Asus Kommando IPMI card, an ast2600 based pcie bmc card
> 
> Signed-off-by: Anirudh Srinivasan <anirudhsriniv@gmail.com>
> ---
>  arch/arm/dts/Makefile                            |  1 +
>  arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts | 98
> ++++++++++++++++++++++++
>  2 files changed, 99 insertions(+)
> 
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index
> 5141c3dc3aa025e2f5c9b2bb98216ee5c72cdf70..fa6837be747da4fbe102ac27e60
> ee3d81e230cb7 100755
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -682,6 +682,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>  	ast2500-genesis3.dtb \
>  	ast2500-romulus.dtb \
>  	ast2600-ampere.dtb \
> +	ast2600-asus-kommando-ipmi-card.dtb \
>  	ast2600-bletchley.dtb \
>  	ast2600-dcscm.dtb \
>  	ast2600-evb-ecc.dtb \
> diff --git a/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts
> b/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts
> new file mode 100644
> index
> 0000000000000000000000000000000000000000..11fee8d5403541f2453f6b8c6f1
> 23c5d1108137d
> --- /dev/null
> +++ b/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts
> @@ -0,0 +1,98 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/dts-v1/;
> +
> +#include "ast2600-u-boot.dtsi"
> +
> +/ {
> +	model = "ASUS Kommando IPMI Card";
> +	compatible = "asus,kommando-ipmi-card", "aspeed,ast2600";
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0x80000000 0x40000000>;
> +	};
> +
> +	chosen {
> +		stdout-path = &uart5;
> +	};
> +
> +	aliases {
> +		spi0 = &fmc;
> +		ethernet0 = &mac2;
> +	};
> +
> +	cpus {
> +		cpu@0 {
> +			clock-frequency = <800000000>;
> +		};
> +		cpu@1 {
> +			clock-frequency = <800000000>;
> +		};
> +	};
> +};
> +
> +&fmc {
> +	status = "okay";
> +
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_fmcquad_default>;
> +
> +	flash@0 {
> +		status = "okay";
> +		spi-max-frequency = <50000000>;
> +		spi-tx-bus-width = <4>;
> +		spi-rx-bus-width = <4>;
> +	};
> +};
> +
> +&hace {
> +	status = "okay";
> +	u-boot,dm-pre-reloc;
> +};
> +
> +&mac2 {
> +	status = "okay";
> +	phy-mode = "rgmii";
> +	phy-handle = <&ethphy2>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_rgmii3_default>;
> +};
> +
> +&mdio {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_mdio3_default>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	ethphy2: ethernet-phy@2 {
> +		reg = <0>;
> +	};
> +};
> +
> +&scu {
> +	mac2-clk-delay = <0x08 0x04
> +			  0x08 0x04
> +			  0x08 0x04>;

Before we go too far down this path, are you aware of the discussions
on the kernel side?

https://lore.kernel.org/all/20260302-rgmii_delay_2600-v6-0-68319a4c4110@aspeedtech.com/

Essentially, can we defer configuring the delays via the SCU here so we
can isolate that problem in the kernel?

I recognise that you might want networking in u-boot as well though :)

> +};
> +
> +&sdrammc {
> +	clock-frequency = <400000000>;
> +};
> +
> +&uart5 {
> +	status = "okay";
> +	u-boot,dm-pre-reloc;
> +};
> +
> +&wdt1 {
> +	status = "okay";
> +};
> +
> +&wdt2 {
> +	status = "okay";
> +};
> +
> +&wdt3 {
> +	status = "okay";
> +};
> 
> ---
> base-commit: d40130c7056b84dc5213f3ff6764d0e45bb84035
> change-id: 20260228-asus-kommando-9de4d6b779a8
> 
> Best regards,


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
  2026-03-05  5:22 ` Andrew Jeffery
@ 2026-03-06  0:32   ` Anirudh Srinivasan
  2026-03-21 22:24     ` Anirudh Srinivasan
  0 siblings, 1 reply; 9+ messages in thread
From: Anirudh Srinivasan @ 2026-03-06  0:32 UTC (permalink / raw)
  To: Andrew Jeffery; +Cc: joel, openbmc

Hi Andrew,

On Wed, Mar 4, 2026 at 11:22 PM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> On Sat, 2026-02-28 at 22:00 -0600, Anirudh Srinivasan wrote:
> > Add dts for Asus Kommando IPMI card, an ast2600 based pcie bmc card
> >
> > Signed-off-by: Anirudh Srinivasan <anirudhsriniv@gmail.com>
> > ---
> >  arch/arm/dts/Makefile                            |  1 +
> >  arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts | 98
> > ++++++++++++++++++++++++
> >  2 files changed, 99 insertions(+)

> > +
> > +&scu {
> > +     mac2-clk-delay = <0x08 0x04
> > +                       0x08 0x04
> > +                       0x08 0x04>;
>
> Before we go too far down this path, are you aware of the discussions
> on the kernel side?
>
> https://lore.kernel.org/all/20260302-rgmii_delay_2600-v6-0-68319a4c4110@aspeedtech.com/
>
> Essentially, can we defer configuring the delays via the SCU here so we
> can isolate that problem in the kernel?

I've been trying to follow that discussion over the last few days, and
the more I read it, the more I get confused.

I went back and looked at the u-boot DT from the Asus fw dump [1], and
there seems to be no mac2-clk-delay in it. That uses u-boot 2019 too.
Not sure how accurate/useful this info is though.

So (correct me if I am wrong)
1. If we don't need this clk delay at all, then I can skip this
clk-delay entry in u-boot and use "rgmii-id" in the linux and u-boot
DTs.
2. If we need this clk delay, u-boot is supposed to configure it
(u-boot DT uses "rgmii") and linux uses "rgmii-id". We don't need to
worry about u-boot patching the linux DT because both use separate
DTs.

This feels like something I should be able to test without any patches
to u-boot/linux. Just try booting u-boot with 2 different DTs (one
with rgmii and one with rgmii-id) and see which scenario networking
works.

Is anything I'm saying correct?

>
> I recognise that you might want networking in u-boot as well though :)

I then read this statement and got confused a bit more.

[1] https://gist.github.com/Genius1237/0b81fcbc8c25a8b516e63e466e8522b1

>
> > +};
> > +
> > +&sdrammc {
> > +     clock-frequency = <400000000>;
> > +};
> > +
> > +&uart5 {
> > +     status = "okay";
> > +     u-boot,dm-pre-reloc;
> > +};
> > +
> > +&wdt1 {
> > +     status = "okay";
> > +};
> > +
> > +&wdt2 {
> > +     status = "okay";
> > +};
> > +
> > +&wdt3 {
> > +     status = "okay";
> > +};
> >
> > ---
> > base-commit: d40130c7056b84dc5213f3ff6764d0e45bb84035
> > change-id: 20260228-asus-kommando-9de4d6b779a8
> >
> > Best regards,



-- 
Regards
Anirudh Srinivasan


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
  2026-03-06  0:32   ` Anirudh Srinivasan
@ 2026-03-21 22:24     ` Anirudh Srinivasan
  2026-03-23 23:42       ` Andrew Jeffery
  0 siblings, 1 reply; 9+ messages in thread
From: Anirudh Srinivasan @ 2026-03-21 22:24 UTC (permalink / raw)
  To: Andrew Jeffery; +Cc: joel, openbmc

Helo Andrew,

After doing some more reading and experimentation, I think I might
have a clearer understanding of how things work.

Andrew Lunn's suggestion in the patch series from Aspeed was to patch
u-boot to not insert clock delays anymore. And then use rgmii-id as
the phy mode in u-boot and linux for all new device trees.

I tested this by setting the mac2 clk delays to 0 in the u-boot device
tree like this

&scu {
    mac2-clk-delay = <0 0
              0 0
              0 0>;
};

Setting the phy-mode to rgmii-id now gives us working networking in
u-boot and linux.

So how do you suggest we proceed here?
1. Add this DT to u-boot now, set phy mode to rgmii-id and set
mac2-clk-delay values to 0. Networking will work in u-boot and linux.
Update the DT to remove the clk delay values once Aspeed updates
u-boot
2. Add this DT to u-boot now. set phy mode to rgmii-id. This means
networking won't work in u-boot, but it works once you're in linux
3. Add this DT to u-boot now without networking. Add networking later
when Aspeed updates u-boot based on the discussion in that thread.
3. Wait for aspeed to update u-boot, then add this DT to u-boot.

In any of these cases, we can also now add networking to the linux DT
for this card (it's missing currently) with phy-mode set to rgmii-id.
No need to wait for Aspeed to update the linux driver (or I think
they're not gonna make any updates at all if it's just u-boot that
needs fixing).

Let me know what you think (or if I've gotten any info incorrect here).

Regards
Anirudh Srinivasan


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
  2026-03-21 22:24     ` Anirudh Srinivasan
@ 2026-03-23 23:42       ` Andrew Jeffery
  2026-03-24  5:08         ` Anirudh Srinivasan
  0 siblings, 1 reply; 9+ messages in thread
From: Andrew Jeffery @ 2026-03-23 23:42 UTC (permalink / raw)
  To: Anirudh Srinivasan; +Cc: joel, openbmc

Hi Anirudh,

Sorry for the delay in reply to this thread.

On Sat, 2026-03-21 at 17:24 -0500, Anirudh Srinivasan wrote:
> Helo Andrew,
> 
> After doing some more reading and experimentation, I think I might
> have a clearer understanding of how things work.
> 
> Andrew Lunn's suggestion in the patch series from Aspeed was to patch
> u-boot to not insert clock delays anymore. And then use rgmii-id as
> the phy mode in u-boot and linux for all new device trees.
> 
> I tested this by setting the mac2 clk delays to 0 in the u-boot device
> tree like this
> 
> &scu {
>     mac2-clk-delay = <0 0
>               0 0
>               0 0>;
> };
> 
> Setting the phy-mode to rgmii-id now gives us working networking in
> u-boot and linux.
> 
> So how do you suggest we proceed here?
> 1. Add this DT to u-boot now, set phy mode to rgmii-id and set
> mac2-clk-delay values to 0. Networking will work in u-boot and linux.
> Update the DT to remove the clk delay values once Aspeed updates
> u-boot
> 2. Add this DT to u-boot now. set phy mode to rgmii-id. This means
> networking won't work in u-boot, but it works once you're in linux
> 3. Add this DT to u-boot now without networking. Add networking later
> when Aspeed updates u-boot based on the discussion in that thread.
> 3. Wait for aspeed to update u-boot, then add this DT to u-boot.
> 
> In any of these cases, we can also now add networking to the linux DT
> for this card (it's missing currently) with phy-mode set to rgmii-id.
> No need to wait for Aspeed to update the linux driver (or I think
> they're not gonna make any updates at all if it's just u-boot that
> needs fixing).

Working backwards here, yes, I think we should add the correct (but not
necessarily yet functional) description to the linux devicetree
(probably best to point out the lack of functionality in a comment in
the relevant devicetree node). 

Then, do your first option 3 above, except add the description of
option 1 in the commit message so people understand how to make
networking function for both environments. That way it's apparent that
anyone who has enabled networking in u-boot is also aware of the
(future) problems of doing so, as they likely will have read that
description. Please add links to the relevant discussions between
Andrew Lunn and Jacky to the commit message as well.

Any concerns with that approach?

> 
> Let me know what you think (or if I've gotten any info incorrect here).

That all sounds about right to me.

Andrew


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
  2026-03-23 23:42       ` Andrew Jeffery
@ 2026-03-24  5:08         ` Anirudh Srinivasan
  2026-03-24 23:23           ` Andrew Jeffery
  0 siblings, 1 reply; 9+ messages in thread
From: Anirudh Srinivasan @ 2026-03-24  5:08 UTC (permalink / raw)
  To: Andrew Jeffery; +Cc: joel, openbmc

Hi Andrew

On Mon, Mar 23, 2026 at 6:42 PM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> Hi Anirudh,
>
> Sorry for the delay in reply to this thread.
>
> On Sat, 2026-03-21 at 17:24 -0500, Anirudh Srinivasan wrote:
> > Helo Andrew,
> >
> > After doing some more reading and experimentation, I think I might
> > have a clearer understanding of how things work.
> >
> > Andrew Lunn's suggestion in the patch series from Aspeed was to patch
> > u-boot to not insert clock delays anymore. And then use rgmii-id as
> > the phy mode in u-boot and linux for all new device trees.
> >
> > I tested this by setting the mac2 clk delays to 0 in the u-boot device
> > tree like this
> >
> > &scu {
> >     mac2-clk-delay = <0 0
> >               0 0
> >               0 0>;
> > };
> >
> > Setting the phy-mode to rgmii-id now gives us working networking in
> > u-boot and linux.
> >
> > So how do you suggest we proceed here?
> > 1. Add this DT to u-boot now, set phy mode to rgmii-id and set
> > mac2-clk-delay values to 0. Networking will work in u-boot and linux.
> > Update the DT to remove the clk delay values once Aspeed updates
> > u-boot
> > 2. Add this DT to u-boot now. set phy mode to rgmii-id. This means
> > networking won't work in u-boot, but it works once you're in linux
> > 3. Add this DT to u-boot now without networking. Add networking later
> > when Aspeed updates u-boot based on the discussion in that thread.
> > 3. Wait for aspeed to update u-boot, then add this DT to u-boot.
> >
> > In any of these cases, we can also now add networking to the linux DT
> > for this card (it's missing currently) with phy-mode set to rgmii-id.
> > No need to wait for Aspeed to update the linux driver (or I think
> > they're not gonna make any updates at all if it's just u-boot that
> > needs fixing).
>
> Working backwards here, yes, I think we should add the correct (but not
> necessarily yet functional) description to the linux devicetree
> (probably best to point out the lack of functionality in a comment in
> the relevant devicetree node).
>
> Then, do your first option 3 above, except add the description of
> option 1 in the commit message so people understand how to make
> networking function for both environments. That way it's apparent that
> anyone who has enabled networking in u-boot is also aware of the
> (future) problems of doing so, as they likely will have read that
> description. Please add links to the relevant discussions between
> Andrew Lunn and Jacky to the commit message as well.

Sounds good. I'll do things in this manner:
1. I'll send v2 of this u-boot patch without networking support, with
a description of how to enable networking in the commit message.
2. I'll send a kernel patch to enable networking with rgmii-id as the
phy mode. The commit message will mention that this requires patched
u-boot without the clock delays (with a link to the above u-boot patch
series).

I'll add links to the discussion between Andrew and Jacky in both.
Once aspeed updates u-boot, we can add networking in u-boot.

>
> Any concerns with that approach?
>
> >
> > Let me know what you think (or if I've gotten any info incorrect here).
>
> That all sounds about right to me.
>
> Andrew



-- 
Regards
Anirudh Srinivasan


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
  2026-03-24  5:08         ` Anirudh Srinivasan
@ 2026-03-24 23:23           ` Andrew Jeffery
  0 siblings, 0 replies; 9+ messages in thread
From: Andrew Jeffery @ 2026-03-24 23:23 UTC (permalink / raw)
  To: Anirudh Srinivasan; +Cc: joel, openbmc

On Tue, 2026-03-24 at 00:08 -0500, Anirudh Srinivasan wrote:
> Hi Andrew
> 
> On Mon, Mar 23, 2026 at 6:42 PM Andrew Jeffery
> <andrew@codeconstruct.com.au> wrote:
> > 
> > Hi Anirudh,
> > 
> > Sorry for the delay in reply to this thread.
> > 
> > On Sat, 2026-03-21 at 17:24 -0500, Anirudh Srinivasan wrote:
> > > Helo Andrew,
> > > 
> > > After doing some more reading and experimentation, I think I might
> > > have a clearer understanding of how things work.
> > > 
> > > Andrew Lunn's suggestion in the patch series from Aspeed was to patch
> > > u-boot to not insert clock delays anymore. And then use rgmii-id as
> > > the phy mode in u-boot and linux for all new device trees.
> > > 
> > > I tested this by setting the mac2 clk delays to 0 in the u-boot device
> > > tree like this
> > > 
> > > &scu {
> > >     mac2-clk-delay = <0 0
> > >               0 0
> > >               0 0>;
> > > };
> > > 
> > > Setting the phy-mode to rgmii-id now gives us working networking in
> > > u-boot and linux.
> > > 
> > > So how do you suggest we proceed here?
> > > 1. Add this DT to u-boot now, set phy mode to rgmii-id and set
> > > mac2-clk-delay values to 0. Networking will work in u-boot and linux.
> > > Update the DT to remove the clk delay values once Aspeed updates
> > > u-boot
> > > 2. Add this DT to u-boot now. set phy mode to rgmii-id. This means
> > > networking won't work in u-boot, but it works once you're in linux
> > > 3. Add this DT to u-boot now without networking. Add networking later
> > > when Aspeed updates u-boot based on the discussion in that thread.
> > > 3. Wait for aspeed to update u-boot, then add this DT to u-boot.
> > > 
> > > In any of these cases, we can also now add networking to the linux DT
> > > for this card (it's missing currently) with phy-mode set to rgmii-id.
> > > No need to wait for Aspeed to update the linux driver (or I think
> > > they're not gonna make any updates at all if it's just u-boot that
> > > needs fixing).
> > 
> > Working backwards here, yes, I think we should add the correct (but not
> > necessarily yet functional) description to the linux devicetree
> > (probably best to point out the lack of functionality in a comment in
> > the relevant devicetree node).
> > 
> > Then, do your first option 3 above, except add the description of
> > option 1 in the commit message so people understand how to make
> > networking function for both environments. That way it's apparent that
> > anyone who has enabled networking in u-boot is also aware of the
> > (future) problems of doing so, as they likely will have read that
> > description. Please add links to the relevant discussions between
> > Andrew Lunn and Jacky to the commit message as well.
> 
> Sounds good. I'll do things in this manner:
> 1. I'll send v2 of this u-boot patch without networking support, with
> a description of how to enable networking in the commit message.
> 2. I'll send a kernel patch to enable networking with rgmii-id as the
> phy mode. The commit message will mention that this requires patched
> u-boot without the clock delays (with a link to the above u-boot patch
> series).
> 
> I'll add links to the discussion between Andrew and Jacky in both.
> Once aspeed updates u-boot, we can add networking in u-boot.

Sounds good!

Thanks,

Andrew



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-03-24 23:24 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-01  4:00 [PATCH] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card Anirudh Srinivasan
2026-03-01  4:10 ` Anirudh Srinivasan
2026-03-02  0:35   ` Andrew Jeffery
2026-03-05  5:22 ` Andrew Jeffery
2026-03-06  0:32   ` Anirudh Srinivasan
2026-03-21 22:24     ` Anirudh Srinivasan
2026-03-23 23:42       ` Andrew Jeffery
2026-03-24  5:08         ` Anirudh Srinivasan
2026-03-24 23:23           ` Andrew Jeffery

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox