From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AB92C5DF97 for ; Sat, 22 Aug 2026 03:21:49 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4hRjBn3pDcz2yDs; Sat, 22 Aug 2026 13:21:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1787311788; cv=none; b=hqKU3Bm+l22zW/6tJ3qhGh6/ytJ4CdP2W5siV5zzlvZdAc/m/qDXIr6krqw+7U7QcGlCasPY5VBG44v+xZSeAZVJEsHt48dX/1Ac8sz6f5F1nUxE7zf2W7zBfzrA4ok6Azr4la/s7B6uSBM3Vml4bAHwp/Rqw9UwrfwGVTyCFQ+g8CwKC2xLCdOEGdM4UHK0LM4b9qFTj0VrwooJKvSlzcArnFzpIJl0b/em6IuZu2B5VztZ+rp5DjsnaS9yqPvUT5YKzEK44nU8LPikn6UaP2t1PPNlgHgEBOvk0DupRNuDuru4NnJsNOB9eHEbeFQhjwITMS1+SnmCCLPuRQYWqA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1787311788; c=relaxed/relaxed; bh=yvXny4Uzt3tUYS9bpKHRNKA1xycDne4ixBPlCcMH+lk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XMeS5neKQ1kn2bWe4QCwn6Cl3wgTXIi/m8Drwabl89i819K13TQ9Arc+fZXk7wxJR960HysrtBvD6kgcQC8Xyrv3XRyISAZAhfuDR2k0KKzng4ePWovSqInuDUH/7k/WrWYGX+9WaOqFLw4ZrM+rU16krbvqRdKpm165nzARWC7QpDJtiQHnaxryFKFviNym8zYmHM8qpAqfDHehbgvu0yZqt2pjJzNQ+RK0ZnDDtZG28JCafMYobINRV3ITTOsoxtQmeAd4xgSMwJ75fHGfvMLiL8TjWRmIEs0DTRh/tWjFcOMWJCkkvVz81dnpaxRytZbDPLpl8Avg0DyeKraOrw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arm.com; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=NWaC1+te; dkim-atps=neutral; spf=pass (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=liviu.dudau@arm.com; receiver=lists.ozlabs.org) smtp.mailfrom=arm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=NWaC1+te; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=liviu.dudau@arm.com; receiver=lists.ozlabs.org) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4hRJ4W5n74z2xBK for ; Fri, 21 Aug 2026 21:29:47 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 995371596 for ; Fri, 21 Aug 2026 04:29:12 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 497DC3F763 for ; Fri, 21 Aug 2026 04:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1787311756; bh=rReboDtVWR+LchIn66VCIiRA4RrsNZEU4pEK04rnFMY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NWaC1+teVndv5tq9fFdOgSI2Ei/T9dLCIUhI/Ks/lshs4FWs4uuqYpb5wgTPIMI9B JDwuS96iUZ2cVwVJ3z/T93IUxsTCA6u/dw1EnCt4yIyneMbiDmWtpEtdVQTn1b4Zs8 1xxSuoPoDUaL/ai8WbJWkLVnt3xixpMau8RQliv0= Date: Fri, 21 Aug 2026 12:28:01 +0100 From: Liviu Dudau To: Geert Uytterhoeven Cc: Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Heiko Stuebner , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , Emilio =?utf-8?B?TMOzcGV6?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Lorenzo Pieralisi , Michal Simek , Matthias Brugger , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 40/45] clk: versatile: Make sure clk_init_data is fully initialized Message-ID: References: <7c480e73222bb51982fb82dc0cc6cd503f2e8b92.1787239813.git.geert+renesas@glider.be> X-Mailing-List: openbmc@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7c480e73222bb51982fb82dc0cc6cd503f2e8b92.1787239813.git.geert+renesas@glider.be> On Fri, Aug 21, 2026 at 10:53:50AM +0200, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Make sure all members are fully initialized, to avoid such bugs, and to > prevent future breakage when converting drivers to a different method > for specifying the parents. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Liviu Dudau Best regards, Liviu > --- > Compile-tested only. > --- > drivers/clk/versatile/clk-icst.c | 2 +- > drivers/clk/versatile/clk-sp810.c | 2 +- > drivers/clk/versatile/clk-vexpress-osc.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c > index 6bd3db54dd229d28..97a1bfd6cf0ed995 100644 > --- a/drivers/clk/versatile/clk-icst.c > +++ b/drivers/clk/versatile/clk-icst.c > @@ -360,8 +360,8 @@ struct clk *icst_clk_setup(struct device *dev, > { > struct clk *clk; > struct clk_icst *icst; > - struct clk_init_data init; > struct icst_params *pclone; > + struct clk_init_data init = {}; > > icst = kzalloc_obj(*icst); > if (!icst) > diff --git a/drivers/clk/versatile/clk-sp810.c b/drivers/clk/versatile/clk-sp810.c > index b0e69686f7a9a93e..28e5c0cf1fda38e4 100644 > --- a/drivers/clk/versatile/clk-sp810.c > +++ b/drivers/clk/versatile/clk-sp810.c > @@ -86,7 +86,7 @@ static void __init clk_sp810_of_setup(struct device_node *node) > const char *parent_names[2]; > int num = ARRAY_SIZE(parent_names); > char name[12]; > - struct clk_init_data init; > + struct clk_init_data init = {}; > static int instance; > int i; > bool deprecated; > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > index 9adbf5c33bd1cada..72e872ec6b7c9b47 100644 > --- a/drivers/clk/versatile/clk-vexpress-osc.c > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > @@ -64,7 +64,7 @@ static const struct clk_ops vexpress_osc_ops = { > > static int vexpress_osc_probe(struct platform_device *pdev) > { > - struct clk_init_data init; > + struct clk_init_data init = {}; > struct vexpress_osc *osc; > u32 range[2]; > int ret; > -- > 2.43.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯