From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A75BC5DF81 for ; Mon, 24 Aug 2026 23:52:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4hTSNt4R1Qz2yr4; Tue, 25 Aug 2026 09:51:26 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1787577414; cv=none; b=GqJv2sAUVId2hJ8owCJuE4ZMEGrO6+uYplUjJqRVtwe280Of0IhP9r/4InF8OY2kZCl1DVeaLlH8WUCzgK+Kl1lvEno2CIta7AnCNO2hCcTtGbJ1yWm6QjRcH266CJm+IN0InYa2AvSVB7dXeETLdfDQQpJujoVcNFdqiI/K2aGpsiKwVETM/qzM43mcmUPE/JNcJKDS2521hexpHAK5rvGSApf3BiaxJKYSW9cSa4nnAqEHHC9WT/501EuQhTmmsLoAzqB1puYmSALu5Ku3tUm7Rp/DZ28PIFxKb4GYjB/Ql6LLs2V8WxJH4WfZ9650qwu5/DXTaihKdMxDEH8oEw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1787577414; c=relaxed/relaxed; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=eF4olFjlG9uyvPxksF1RtCOp/Iq9OpDkaAAhiFmvt8sNUqAyqygAiHsq36rxzzw9OS/YvO0QbQWVAavJFDdC5VsNhLRL8IvM82TmxXRlTMSR5JVWRf2Y62CaL9+H30j1PFWQ+w1yj8Kr0UXFZ8qliZrRdcuB+732OhtlNSCiSU5SpTmY04THkt3bYNN4HWLxH49b74WcpJYM3JUIWT4Fdcos2y8wP4uWblnhOhnl5PxxzXYGnPhyBKZNYMAirOiwmr+5z//7Ia5zLieN9mwaaXULtFj/76WC+K2ImieJNPzZI5MDz8RxCEIOp4BURMs99Wo+Gk/cBQaZITQh/B2zug== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Yt2qQfWI; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IKg/D0on; dkim-atps=neutral; spf=pass (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=bmasney@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Yt2qQfWI; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IKg/D0on; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=bmasney@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4hTBJj0mmvz2xnQ for ; Mon, 24 Aug 2026 23:16:50 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787577405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=Yt2qQfWIpvra9OdM7gDDW3etGkeqEgtGb6YiRhLqOsf27nRSbUrfF6mJUa9/Jm+7hF0CA/ Mx8vJ2x8NHR5UEZyHU7Vb93UVBj1V7Vc044wIY3ZzE4iU3tOMCgUkrmIkMJmcq9QXh6KEn 2GLT1s9ZGLJB0PuCtZAiwbj0g++2RoA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787577406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=IKg/D0on6WuGIEkDRlaA0AGzaoUcMm9W7vHGwfBWAJy9PM1TAsZ835LTmG9fe7n+UgnIFF bvopKA+EBWEpOmco21ROIk5dc1pKqA14gO8mCCyOW4PPReTY0qxr9Q2Eqkr9ZRnyin93aC 96Kp3cH7vPISNQm2ue5R69NB2ZqffVM= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-UGPSKw6iOrWyF7DUmquBKw-1; Mon, 24 Aug 2026 09:16:44 -0400 X-MC-Unique: UGPSKw6iOrWyF7DUmquBKw-1 X-Mimecast-MFC-AGG-ID: UGPSKw6iOrWyF7DUmquBKw_1787577403 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-836c9f68dcbso59404507b3.0 for ; Mon, 24 Aug 2026 06:16:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787577403; x=1788182203; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=a1A6TOBtGG/BAZv8SSwyk5k9ALicLxyZtUg2Y3Z06bmVptv4AAgNCfcJTFHIv1hN2b HSyi3eI37Bsl07RVMweldpQkMEFljLdlb4CiSdxZWHMhHP2cYEFlCLkMLEKccjNeSDmu Mp7QPd3EtNjWjkDJv/i2furce9NqZRU9zqRcg2qDzMPeMI3cMeyPpE6P4xAM2HDyuJNF AdVJRyiaJhF7euz9RCQhhKOLIHdyqZNa7ZA7S1D6pMp9vpfwcr3tjx2iOaFx5su7KKHY z908EI+4QjHys+l+TguiQdzsmwlmutNjYVFdzG8vle8iD7AUOFSU+4/vdnJCy25HwU93 2lCA== X-Forwarded-Encrypted: i=1; AHgh+RpDZkM8IiKKcWRtp2sFbb7CyZ/FoeLv/iAFyvcab4wYf888KpYY8V3/DSVafnO3xPrm1YltfkRd@lists.ozlabs.org X-Gm-Message-State: AFuF++kPXh1AQKUEee2awVJh86SlbeQtErSrsD0sxDgLOTxZkWjGEPt1 lAKijMumDD96dEqTydxF04Iza4+Sj/IFJkxTKpRvtPOxT4CyFBulJSTgFuW3f0u+hfvwqhdclrU gvGVGJqlsnLZZK9cCw844LfeetbWlWWgnzC9k0xudJIK7QYCOJ9IMnJ9n5fKI X-Gm-Gg: AR+sD11T9/U+xPwY/bBAZEjFHtCM7M3TqxdbkK0JQJ7v5Y7XdfcfghlLlgCQPLlQ3j+ 0Ig7O/pn8EjhMjiCmb+NS3sQ8L/SKXjpZ+glVuAfQDamgxwlz6Xr6R6Xh7lMC+xFSKjSSMHE5A8 kcih61WMx4g/43mH4Xnz+qg0MFhONG5jvwX4Wr8j4G+/tkScR7txZFFgz7pwiYjH17HVGlJiCxV 5098W+zNlr3WD80cjPnciCaVJv22Q+P6KG3mnTB+pPx1rH3BZpFLFzeoUa0OtqaAUSambkqKP3c VGOh9ods1kz4RS+IspQHsagrBttRcDfI2m+92OYl60fj3X8gV/XkAMJptIE7NTPepTDr5LKUfVz T6EAsiSpezb79/u0pWR7B+Z3ytGDu2EwXQUk= X-Received: by 2002:a05:690c:e0c1:10b0:81e:a4cf:131b with SMTP id 00721157ae682-849f4a7cc91mr76172857b3.22.1787577403093; Mon, 24 Aug 2026 06:16:43 -0700 (PDT) X-Received: by 2002:a05:690c:e0c1:10b0:81e:a4cf:131b with SMTP id 00721157ae682-849f4a7cc91mr76172227b3.22.1787577402495; Mon, 24 Aug 2026 06:16:42 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84ca5d254adsm33243617b3.16.2026.08.24.06.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 06:16:41 -0700 (PDT) Date: Mon, 24 Aug 2026 09:16:34 -0400 From: Brian Masney To: Krzysztof Kozlowski Cc: Geert Uytterhoeven , Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Heiko Stuebner , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , Emilio =?iso-8859-1?Q?L=F3pez?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Liviu Dudau , Lorenzo Pieralisi , Michal Simek , Matthias Brugger , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 29/45] clk: samsung: Make sure clk_init_data is fully initialized Message-ID: References: <87b3e83137e1a987f3c69d214706e93ef3898cab.1787239813.git.geert+renesas@glider.be> <60a8d05a-76fa-43c3-a0f7-fb26a3b659b8@kernel.org> X-Mailing-List: openbmc@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 In-Reply-To: <60a8d05a-76fa-43c3-a0f7-fb26a3b659b8@kernel.org> User-Agent: Mutt/2.4.0 (2026-06-19) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8L7JZYcRkhz6RLBJWpJBS3NHv3W-9P-SenDg0fjiAWg_1787577403 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Krzysztof, On Fri, Aug 21, 2026 at 01:04:01PM +0200, Krzysztof Kozlowski wrote: > On 21/08/2026 10:53, Geert Uytterhoeven wrote: > > The clk_init_data structure contains several mutually-exclusive members > > for different methods to specify the possible parents of a clock, > > prompting drivers to initialize only the members they need. However, > > not initializing all members may cause subtle issues, which are only > > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > > enabled. > > > > Make sure all members are fully initialized, to avoid such bugs, and to > > prevent future breakage when converting drivers to a different method > > for specifying the parents. > > > > Signed-off-by: Geert Uytterhoeven > > --- > > Compile-tested only. > > --- > > drivers/clk/samsung/clk-cpu.c | 2 +- > > drivers/clk/samsung/clk-pll.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > Reviewed-by: Krzysztof Kozlowski > > Let me know if I should take it via Samsung SoC clock tree. I assume by > default this will go directly via clock tree. Please take it through your Samsung tree to avoid merge conflicts if there are other changes to these files during this development cycle. Brian