From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tomer Maimon <tmaimon77@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au,
venture@google.com, yuenn@google.com, benjaminfair@google.com
Cc: openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] arm64: dts: nuvoton: fix warning and nodes order
Date: Sun, 19 Oct 2025 12:35:16 +0200 [thread overview]
Message-ID: <cc23d41d-6a5e-44d7-ad4b-1b39566dbce8@kernel.org> (raw)
In-Reply-To: <20250925200625.573902-2-tmaimon77@gmail.com>
On 25/09/2025 22:06, Tomer Maimon wrote:
> Fix the warning in the gcr and timer nodes, and modify nodes order by
What warning?
> ascending unit address.
Why are you combining multiple issues into one commit. No. Read
submitting patches how to organize your work.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 35 +++++++++----------
> 1 file changed, 17 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index 24133528b8e9..a43514f624c0 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -18,7 +18,7 @@ soc {
> ranges;
>
> gcr: system-controller@f0800000 {
> - compatible = "nuvoton,npcm845-gcr", "syscon";
> + compatible = "nuvoton,npcm845-gcr", "syscon", "simple-mfd";
This makes no sense. No children here.
> reg = <0x0 0xf0800000 0x0 0x1000>;
> };
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-19 10:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 20:06 [PATCH v3 0/3] arm64: dts: nuvoton: add NPCM845 SoC and EVB support Tomer Maimon
2025-09-25 20:06 ` [PATCH v3 1/3] arm64: dts: nuvoton: fix warning and nodes order Tomer Maimon
2025-10-19 10:35 ` Krzysztof Kozlowski [this message]
2025-10-19 14:30 ` Tomer Maimon
2025-10-19 16:52 ` Krzysztof Kozlowski
2025-09-25 20:06 ` [PATCH v3 2/3] arm64: dts: nuvoton: npcm845: Add peripheral nodes Tomer Maimon
2025-09-25 20:06 ` [PATCH v3 3/3] arm64: dts: nuvoton: npcm845-evb: " Tomer Maimon
2025-09-26 16:11 ` [PATCH v3 0/3] arm64: dts: nuvoton: add NPCM845 SoC and EVB support Rob Herring (Arm)
2025-09-29 9:15 ` Tomer Maimon
2025-10-01 2:35 ` Andrew Jeffery
2025-10-16 9:06 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc23d41d-6a5e-44d7-ad4b-1b39566dbce8@kernel.org \
--to=krzk@kernel.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox