Re: [PATCH 02/17] spi: bcm63xx-hsspi: Use helper function devm_clk_get_enabled()

Mark Brown
2026-03-12T12:57:07Z

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

On Thu, Mar 12, 2026 at 05:28:54PM +0800, Pei Xiao wrote:

> - ret = clk_prepare_enable(pll_clk);
> - if (ret)
> - goto out_disable_clk;
> + pll_clk = devm_clk_get_enabled(dev, "pll");
> + if (IS_ERR(pll_clk))
> + return dev_err_probe(dev, PTR_ERR(pll_clk), "failed
> + enable pll clk\n");

It's nice to print an error message but having a line break in the
middle of a string not so much, put the "failed bit on the same line as
the rest of the error.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]