From: Eddie James <eajames@linux.ibm.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Ninad Palsule <ninad@linux.ibm.com>,
linux-fsi@lists.ozlabs.org, Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/13] i2c: fsi: Drop assigning fsi bus
Date: Tue, 27 Jan 2026 09:26:05 -0600 [thread overview]
Message-ID: <e8b4d09c-f034-4e2f-9f05-109acd074864@linux.ibm.com> (raw)
In-Reply-To: <8a36a0dba809d3bfe225627fd178daece10ff6a5.1765279318.git.u.kleine-koenig@baylibre.com>
On 12/9/25 5:40 AM, Uwe Kleine-König wrote:
> Since commit FIXME ("fsi: Assign driver's bus in fsi_driver_register()")
> module_fsi_driver() cares about assigning the driver's bus member. Drop
> the explicit driver specific assignment.
Acked-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
> ---
> drivers/i2c/busses/i2c-fsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c
> index ae016a9431da..e98dd5dcac0f 100644
> --- a/drivers/i2c/busses/i2c-fsi.c
> +++ b/drivers/i2c/busses/i2c-fsi.c
> @@ -763,7 +763,6 @@ static struct fsi_driver fsi_i2c_driver = {
> .id_table = fsi_i2c_ids,
> .drv = {
> .name = "i2c-fsi",
> - .bus = &fsi_bus_type,
> .probe = fsi_i2c_probe,
> .remove = fsi_i2c_remove,
> },
next prev parent reply other threads:[~2026-01-27 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 11:39 [PATCH v2 00/13] fsi: Convert to bus probe mechanism Uwe Kleine-König
2025-12-09 11:40 ` [PATCH v2 04/13] i2c: fsi: Drop assigning fsi bus Uwe Kleine-König
2026-01-27 15:26 ` Eddie James [this message]
2025-12-09 11:40 ` [PATCH v2 12/13] i2c: fsi: Convert to fsi bus probe mechanism Uwe Kleine-König
2026-01-27 15:29 ` Eddie James
2026-01-12 9:47 ` [PATCH v2 00/13] fsi: Convert to " Uwe Kleine-König
2026-01-27 15:31 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8b4d09c-f034-4e2f-9f05-109acd074864@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=andi.shyti@kernel.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ninad@linux.ibm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox