Re: [PATCH v2 1/1] Add a tune file for cortexa53, valid for 32 bits and 64 bits

From: Herve Jourdain <herve.jourdain@neuf.fr>
To: 'Khem Raj' <raj.khem@gmail.com>
Cc: 'Patches and discussions about the oe-core layer'
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 1/1] Add a tune file for cortexa53, valid for 32 bits and 64 bits
Date: Sun, 20 Nov 2016 09:05:18 +0100	[thread overview]
Message-ID: <003001d24304$d82c5580$88850080$@neuf.fr> (raw)
In-Reply-To: <CAMKF1so0YG5cy49tG2Efm-arFfxDbEoZgrP_5JNM9+ch_pr=cg@mail.gmail.com>

Hi Khem,

Unfortunately, it has a few issues in 32bits mode...
Basically, cortex-a53 is an armv8+crc...
I'm sending an updated version - v3 - soon.
But I'll run the tune checker first. At least, the new version I'm coming up with and plan to send soon seems to work fine now with 32bits - and I shouldn't have broken the 64bits support in the process, but I will also compile it.

Herve

-----Original Message-----
From: Khem Raj [mailto:raj.khem@gmail.com] 
Sent: samedi 19 novembre 2016 18:51
To: Herve Jourdain <herve.jourdain@neuf.fr>
Cc: Patches and discussions about the oe-core layer <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [oe-core][PATCH v2 1/1] Add a tune file for cortexa53, valid for 32 bits and 64 bits

This seems fine to me. There is a tune checker that Martin has, it would be good to run that and see if this new tune is tested.

http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test

On Sat, Nov 19, 2016 at 4:50 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> ---
>  meta/conf/machine/include/tune-cortexa53.inc | 22 
> ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta/conf/machine/include/tune-cortexa53.inc
>
> diff --git a/meta/conf/machine/include/tune-cortexa53.inc 
> b/meta/conf/machine/include/tune-cortexa53.inc
> new file mode 100644
> index 0000000..ff5edb6
> --- /dev/null
> +++ b/meta/conf/machine/include/tune-cortexa53.inc
> @@ -0,0 +1,22 @@
> +DEFAULTTUNE ?= "cortexa53-32"
> +
> +require conf/machine/include/arm/arch-armv8.inc
> +
> +TUNEVALID[cortexa53] = "Enable Cortex-A53 specific processor optimizations"
> +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa53', ' -mcpu=cortex-a53 ', '',d)}"
> +
> +# Extra tune selections
> +AVAILTUNES += "cortexa53-32"
> +ARMPKGARCH_tune-cortexa53-32 ?= "cortexa53"
> +TUNE_FEATURES_tune-cortexa53-32 = "${TUNE_FEATURES_tune-armv7ve-neon-vfpv4} cortexa53"
> +BASE_LIB_tune-cortexa53-32 = "lib"
> +TUNE_PKGARCH_tune-cortexa53-32 = "cortexa53-32"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa53-32 = "${PACKAGE_EXTRA_ARCHS_tune-armv7ve-neon-vfpv4} cortexa53-32 cortexa53-neon-vfpv4"
> +
> +AVAILTUNES += "cortexa53-64"
> +ARMPKGARCH_tune-cortexa53-64 ?= "cortexa53"
> +TUNE_FEATURES_tune-cortexa53-64 = "${TUNE_FEATURES_tune-aarch64} cortexa53"
> +BASE_LIB_tune-cortexa53-64 = "lib64"
> +TUNE_PKGARCH_tune-cortexa53-64 = "cortexa53-64"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa53-64 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa53-64"
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core