From: "Li Zhijian" <lizhijian@cn.fujitsu.com>
To: "'Saul Wold'" <sgw@linux.intel.com>,
<openembedded-core@lists.openembedded.org>,
"'Burton, Ross'" <ross.burton@intel.com>
Subject: Re: [PATCH] systemd.bbclass: do not call 'systemctl restart ${SYSTEMD_SERVICE}' at systemd_postinst
Date: Tue, 19 Nov 2013 10:24:52 +0800 [thread overview]
Message-ID: <008601cee4ce$8834a330$989de990$@cn.fujitsu.com> (raw)
In-Reply-To: <527402CF.7060401@linux.intel.com>
Sau，Ross，
How about it
--
Best regards.
Li Zhijian
|-----Original Message-----
|From: Saul Wold [mailto:sgw@linux.intel.com]
|Sent: Saturday, November 02, 2013 3:37 AM
|To: Li Zhijian; openembedded-core@lists.openembedded.org; Burton, Ross
|Subject: Re: [OE-core] [PATCH] systemd.bbclass: do not call 'systemctl
|restart ${SYSTEMD_SERVICE}' at systemd_postinst
|
|On 10/23/2013 12:34 AM, Li Zhijian wrote:
|> From: Li Zhijian <lizhijian@cn.fujitsu.com>
|>
|> If systemd_postinst is installed as a delayed package scriptlet
(installed
|to /etc/rpm-postints/${PN})
|> which would be executed at the first time of OS startup. And then this
|script would block when it is
|> trying to call systemctl to restart service.
|>
|> It seems that it is not a good timing to restart service at
run-postinsts.
|> I test serval services which has supported systemd(uuidd/avahi-daemon),
|all of them
|> will block the startup.
|>
|
|Ross,
|
|Can you have a look at this change.
|
|Thanks
| Sau!
|
|
|> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
|> ---
|> meta/classes/systemd.bbclass | 4 ----
|> 1 files changed, 0 insertions(+), 4 deletions(-)
|>
|> diff --git a/meta/classes/systemd.bbclass
|b/meta/classes/systemd.bbclass
|> index 3700b2e..7aa5459 100644
|> --- a/meta/classes/systemd.bbclass
|> +++ b/meta/classes/systemd.bbclass
|> @@ -31,10 +31,6 @@ fi
|> if type systemctl >/dev/null 2>/dev/null; then
|> systemctl $OPTS ${SYSTEMD_AUTO_ENABLE} ${SYSTEMD_SERVICE}
|> -
|> - if [ -z "$D" -a "${SYSTEMD_AUTO_ENABLE}" = "enable" ]; then
|> - systemctl restart ${SYSTEMD_SERVICE}
|> - fi
|> fi
|> }
|> -- 1.7.1
|>
|>
|>
|>
|> _______________________________________________
|> Openembedded-core mailing list
|> Openembedded-core@lists.openembedded.org
|> http://lists.openembedded.org/mailman/listinfo/openembedded-core
|>
next prev parent reply other threads:[~2013-11-19 2:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 7:34 [PATCH] systemd.bbclass: do not call 'systemctl restart ${SYSTEMD_SERVICE}' at systemd_postinst Li Zhijian
2013-11-01 19:36 ` Saul Wold
2013-11-19 2:24 ` Li Zhijian [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-23 10:53 Yevhen Kyriukha
2013-10-23 11:27 ` Li Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008601cee4ce$8834a330$989de990$@cn.fujitsu.com' \
--to=lizhijian@cn.fujitsu.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox