public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Steve Sakoman <steve@sakoman.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][dunfell 07/17] image: Drop COMPRESS_CMD
Date: Fri, 13 Aug 2021 22:56:56 +0100	[thread overview]
Message-ID: <00a408d147c98960dbf2bb8980bd20a1b6616b7a.camel@linuxfoundation.org> (raw)
In-Reply-To: <3ebaa86707ea99e8272dafc442318e3a5f483018.1628863869.git.steve@sakoman.com>

On Fri, 2021-08-13 at 04:29 -1000, Steve Sakoman wrote:
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> This was replaced by CONVERSION_CMD a long time ago and is no longer referenced
> in core. Remove the references to it.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit 576d52cdaca047d290c3b10b26aa2244da230dbb)
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  meta/classes/image.bbclass | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 1900eff412..0e252e99ff 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -460,11 +460,10 @@ python () {
>                      # Create input image first.
>                      gen_conversion_cmds(type)
>                      localdata.setVar('type', type)
> -                    cmd = "\t" + (localdata.getVar("CONVERSION_CMD_" + ctype) or localdata.getVar("COMPRESS_CMD_" + ctype))
> +                    cmd = "\t" + localdata.getVar("CONVERSION_CMD_" + ctype)
>                      if cmd not in cmds:
>                          cmds.append(cmd)
>                      vardeps.add('CONVERSION_CMD_' + ctype)
> -                    vardeps.add('COMPRESS_CMD_' + ctype)
>                      subimage = type + "." + ctype
>                      if subimage not in subimages:
>                          subimages.append(subimage)

Not sure this is appropriate for a stable series?

Yes, we got rid of this a while ago and there are no core references but
there is a small chance other layers might.

Cheers,

Richard


  reply	other threads:[~2021-08-13 21:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 14:29 [OE-core][dunfell 00/17] Patch review Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 01/17] aspell: fix CVE-2019-25051 Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 02/17] systemd: Add fix for CVE-2020-13529 and CVE-2021-33910 Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 03/17] glibc: Document and whitelist CVE-2021-35942 Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 04/17] libsolv: fix CVE-2021-3200 Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 05/17] ruby: 2.7.3 -> 2.7.4 Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 06/17] license: Exclude COPYING.MIT from pseudo Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 07/17] image: Drop COMPRESS_CMD Steve Sakoman
2021-08-13 21:56   ` Richard Purdie [this message]
2021-08-13 22:00     ` Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 08/17] kernel-yocto: Simplify no git repo case in do_kernel_checkout Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 09/17] runqemu: Fix typo in error message Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 10/17] cve-check: add include/exclude layers Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 11/17] cve-check: fix comments Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 12/17] cve-check: update link to NVD website for CVE details Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 13/17] cve-check: improve comment about CVE patch file names Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 14/17] cve-check: remove deprecated CVE_CHECK_CVE_WHITELIST Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 15/17] e2fsprogs: ensure small images have 256-byte inodes Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 16/17] wic: don't forcibly pass -T default Steve Sakoman
2021-08-13 14:29 ` [OE-core][dunfell 17/17] sstate.bbclass: fix error handling when sstate mirrors is ro Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00a408d147c98960dbf2bb8980bd20a1b6616b7a.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=steve@sakoman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox