From: Deepesh Varatharajan <deepesh.varatharajan@windriver.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: openembedded-core@lists.openembedded.org,
Shivaprasad.Moodalappa@windriver.com,
Sundeep.Kokkonda@windriver.com
Subject: Re: [OE-core] [PATCH V4 2/3] rust: Upgrade 1.82.0->1.83.0
Date: Fri, 14 Mar 2025 10:08:50 +0530 [thread overview]
Message-ID: <013eb7e2-7096-4529-a6a8-e981119af44a@windriver.com> (raw)
In-Reply-To: <CANNYZj-sGPdJT9XghUQQ2XOvn+QatnH0fqP7_Kg5WQHYmyXtmQ@mail.gmail.com>
On 12-03-2025 15:22, Alexander Kanavin wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Wed, 5 Mar 2025 at 14:45, Varatharajan, Deepesh via
> lists.openembedded.org
> <deepesh.varatharajan=windriver.com@lists.openembedded.org> wrote:
>> +++ b/meta/recipes-devtools/rust/files/revert-Zdual-proc-macros-additional-check.patch
>> @@ -0,0 +1,43 @@
>> +rust: Fix build failure for v1.83 when lib32 enabled
>> +
>> +Because of the following commit ,
>> +https://github.com/rust-lang/rust/commit/68034f837a39387e49fc7d7c5b088f5372a1127e
>> +when we enable lib32, getting build failure because there is a check for target
>> +support for "-Zdual-proc-macros" flag not functioning properly when lib32 is
>> +enabled in the build environment. So for now reverting this commit and bring
>> +back the previous behavior, where the "-Zdual-proc-macros" flag is always
>> +added for building proc macros, regardless of the target architecture's support.
>> +This would bypass the check introduced in the patch, allowing the build to
>> +proceed without error, even when building for a 64-bit architecture with lib32 enabled.
>> +
>> +Upstream-Status: Pending
>> +
>> +Signed-off-by: Deepesh Varatharajan <Deepesh.Varatharajan@windriver.com>
>> +diff --git a/src/bootstrap/src/core/builder.rs b/src/bootstrap/src/core/builder.rs
> Please do not add new 'Pending' patches, especially without specifying
> the reason for not submitting them. They tend to stay 'Pending'
> forever and are discouraged for that reason.
>
> Rather, submit them upstream before sending them to oe-core, mark them
> as Inappropriate (with reason and link to upstream ticket), or in rare
> cases, explain what event needs to happen before 'Pending' status
> becomes something else.
Since the new commit added in 1.83 is causing a failure when multilib is
enabled, and it is a blocking issue for version 1.83,
the commit has been reverted, and the update has been proceeded with. An
issue will be raised upstream,
and the patch status will be updated when submitting the 1.84 update.
Regards,
Deepesh
>
> Alex
next prev parent reply other threads:[~2025-03-14 4:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 13:44 [PATCH V4 1/3] rust: Fix build break because of download-ci-llvm Deepesh.Varatharajan
2025-03-05 13:44 ` [PATCH V4 2/3] rust: Upgrade 1.82.0->1.83.0 Deepesh.Varatharajan
2025-03-07 21:02 ` [OE-core] [PATCH V4 2/3] rust: Upgrade 1.82.0->1.83.0 --> bloat alert !! Randy MacLeod
2025-03-07 23:37 ` Richard Purdie
2025-03-13 18:48 ` Randy MacLeod
2025-03-14 12:32 ` Yash Shinde
2025-03-14 12:52 ` Yash Shinde
2025-03-14 13:48 ` Randy MacLeod
2025-03-14 15:50 ` Yash Shinde
2025-03-18 0:35 ` Randy MacLeod
2025-03-18 10:34 ` Yash Shinde
2025-03-12 9:52 ` [OE-core] [PATCH V4 2/3] rust: Upgrade 1.82.0->1.83.0 Alexander Kanavin
2025-03-14 4:38 ` Deepesh Varatharajan [this message]
2025-03-05 13:44 ` [PATCH V4 3/3] rust: Oe-selftest changes for rust v1.83.0 Deepesh.Varatharajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=013eb7e2-7096-4529-a6a8-e981119af44a@windriver.com \
--to=deepesh.varatharajan@windriver.com \
--cc=Shivaprasad.Moodalappa@windriver.com \
--cc=Sundeep.Kokkonda@windriver.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox