Re: [OE-core][PATCH 0/4] Move crate fetcher to OE_IMPORTS

[Paul Barker <paul.barker@sancloud.com>]

On 20/12/2021 22:34, Richard Purdie wrote:
> On Mon, 2021-12-20 at 17:01 +0000, Paul Barker wrote:
>> On 17/12/2021 15:36, Matt Madison wrote:
>>> This patch series switches to using the OE_IMPORTS mechanism
>>> for installing the crate fetcher. This simplifies the addition
>>> and clears up issues with interactions between SRCPV and
>>> the shared-state fetching logic.
>>>
>>> Matt Madison (4):
>>>     lib/crate.py: install crate fetcher on import
>>>     base.bbclass: add crate to OE_IMPORTS
>>>     cargo_common.bbclass: remove inherit of crate-fetch
>>>     classes: remove crate-fetch.bbclass
>>>
>>>    meta/classes/base.bbclass         |  2 +-
>>>    meta/classes/cargo_common.bbclass |  2 --
>>>    meta/classes/crate-fetch.bbclass  | 28 ----------------------------
>>>    meta/lib/crate.py                 |  2 ++
>>>    4 files changed, 3 insertions(+), 31 deletions(-)
>>>    delete mode 100644 meta/classes/crate-fetch.bbclass
>>>
>>
>> Would a better solution here be to move the crate fetcher into
>> lib/bb/fetch2/ in bitbake?
> 
> I've been wondering about this too.
> 
> Does anyone remember how the fetcher lines up against the general fetcher
> requirements we have and is there a list of anything that remained to be done
> before it could be added to bitbake?

If I remember correctly, it just needed some test cases writing. The 
crate fetcher is a subclass of the wget fetcher with changes to how 
urldata is set up and how unpack is handled, so it should integrate well 
into bitbake.

Thanks,

-- 
Paul Barker
Principal Software Engineer
SanCloud Ltd

e: paul.barker@sancloud.com
w: https://sancloud.co.uk/