public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] gcc-runtime: Fix build when using gold
Date: Fri, 15 Jul 2022 12:58:20 -0400	[thread overview]
Message-ID: <02209961-0c06-6d40-4968-c91e7ffe71a3@gmail.com> (raw)
In-Reply-To: <20220714091524.475739-1-richard.purdie@linuxfoundation.org>



On 7/14/22 5:15 AM, Richard Purdie wrote:
> If gold is enabled as the default linker, it errors trying to link
> to our dummy library empty file and this turns off things which should
> be present in libstdc++.
> 
> For example, _GLIBCXX_HAVE_S_ISREG isn't defined and HAVE_S_ISREG in
> libstdc++-v3/config.h isn't set properly.
> 
> Instead of just creating an empty file, create an empty elf binary
> instead which addresses the issue.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>   meta/recipes-devtools/gcc/gcc-runtime.inc | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc b/meta/recipes-devtools/gcc/gcc-runtime.inc
> index c39a0caf8a7..7e920df2d34 100644
> --- a/meta/recipes-devtools/gcc/gcc-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
> @@ -68,7 +68,8 @@ do_configure () {
>   	# libstdc++ isn't built yet so CXX would error not able to find it which breaks stdc++'s configure
>   	# tests. Create a dummy empty lib for the purposes of configure.
>   	mkdir -p ${WORKDIR}/dummylib
> -	touch ${WORKDIR}/dummylib/libstdc++.so
> +	touch ${WORKDIR}/dummylib/dummylib.c
> +	${CC} ${WORKDIR}/dummylib/dummylib.c -shared -o ${WORKDIR}/dummylib/libstdc++.so

you can improve it a little by using a one liner

${CC} -x c /dev/null -shared -o ${WORKDIR}/dummylib/libstdc++.so

>   	for d in libgcc ${RUNTIMETARGET}; do
>   		echo "Configuring $d"
>   		rm -rf ${B}/${TARGET_SYS}/$d/
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#168028): https://lists.openembedded.org/g/openembedded-core/message/168028
> Mute This Topic: https://lists.openembedded.org/mt/92375338/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


      reply	other threads:[~2022-07-15 16:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14  9:15 [PATCH] gcc-runtime: Fix build when using gold Richard Purdie
2022-07-15 16:58 ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02209961-0c06-6d40-4968-c91e7ffe71a3@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox