public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Steve Sakoman <steve@sakoman.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][dunfell 06/12] gtk-icon-cache.bbclass: add features_check
Date: Tue, 04 Aug 2020 22:47:21 +0100	[thread overview]
Message-ID: <0345b07862124c6a7c14ba32284cbef88b7313d0.camel@linuxfoundation.org> (raw)
In-Reply-To: <8f55aa8139347e8ac491002f10d1ba220430ea82.1596464561.git.steve@sakoman.com>

On Mon, 2020-08-03 at 04:26 -1000, Steve Sakoman wrote:
> From: Changqing Li <changqing.li@windriver.com>
> 
> 'bitbake world -k' when DISTRO_FEATURES don't have x11 and wayland,
> report errors:
> Nothing PROVIDES 'gtk+3'
> Nothing RPROVIDES 'blueman'
> 
> gtk+3 set ANY_OF_DISTRO_FEATURES, so add it here too
> since we DEPENDS on it
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit ab9ff563c77cd5105f4ef9426f076b10ea8e2ee8)
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  meta/classes/gtk-icon-cache.bbclass | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-
> icon-cache.bbclass
> index dd394af27c..340a283851 100644
> --- a/meta/classes/gtk-icon-cache.bbclass
> +++ b/meta/classes/gtk-icon-cache.bbclass
> @@ -1,5 +1,10 @@
>  FILES_${PN} += "${datadir}/icons/hicolor"
>  
> +#gtk+3 reqiure GTK3DISTROFEATURES, DEPENDS on it make all the
> +#recipes inherit this class require GTK3DISTROFEATURES
> +inherit features_check
> +ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
> +

Sorry, I understand now. I'd suggest we don't backport this as it
causes problems in other layers and is probably too invasive for the
LTS.

Cheers,

Richard


  reply	other threads:[~2020-08-04 21:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 14:26 [OE-core][dunfell 00/12] Patch review Steve Sakoman
2020-08-03 14:26 ` [OE-core][dunfell 01/12] initscripts: Fix various shellcheck warnings in populate-volatile.sh Steve Sakoman
2020-08-03 14:26 ` [OE-core][dunfell 02/12] initscripts: Fix populate-volatile.sh bug when file/dir exists Steve Sakoman
2020-08-03 14:26 ` [OE-core][dunfell 03/12] checklayer: check layer in BBLAYERS before test Steve Sakoman
2020-08-03 14:26 ` [OE-core][dunfell 04/12] cve-update: handle baseMetricV2 as optional Steve Sakoman
2020-08-03 14:26 ` [OE-core][dunfell 05/12] layer.conf: fix adwaita-icon-theme signature change problem Steve Sakoman
2020-08-04 21:46   ` Richard Purdie
2020-08-05  5:59     ` Martin Jansa
2020-08-05  6:18       ` Khem Raj
2020-08-05 14:13         ` Steve Sakoman
2020-08-03 14:26 ` [OE-core][dunfell 06/12] gtk-icon-cache.bbclass: add features_check Steve Sakoman
2020-08-04 21:47   ` Richard Purdie [this message]
2020-08-05  1:59     ` Steve Sakoman
2020-08-03 14:26 ` [OE-core][dunfell 07/12] cogl-1.0: correct X11 dependencies Steve Sakoman
2020-08-03 14:27 ` [OE-core][dunfell 08/12] boost: backport fix to make async_pipes work with asio Steve Sakoman
2020-08-03 14:27 ` [OE-core][dunfell 09/12] bind: upgrade 9.11.19 -> 9.11.21 Steve Sakoman
2020-08-03 14:27 ` [OE-core][dunfell 10/12] gnutls: upgrade 3.6.13 -> 3.6.14 Steve Sakoman
2020-08-03 14:27 ` [OE-core][dunfell 11/12] gnutls: Fix krb5 code license to GPLv2.1+ to match the LICENSE file Steve Sakoman
2020-08-03 14:27 ` [OE-core][dunfell 12/12] glib-networking: upgrade 2.62.3 to 2.62.4 Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0345b07862124c6a7c14ba32284cbef88b7313d0.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=steve@sakoman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox