Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>,
	 openembedded-core@lists.openembedded.org
Cc: Jon Mason <Jon.Mason@arm.com>
Subject: Re: [PATCH v2 1/3] oeqa: Fix for QEMU_USE_KVM
Date: Mon, 07 Jan 2019 15:24:00 +0000	[thread overview]
Message-ID: <036334051f2c318eb35e0983ffb3df3931757747.camel@linuxfoundation.org> (raw)
In-Reply-To: <f20642eb8822150fa43d2c9fada6c5c36c1d08e7.1546585931.git.liezhi.yang@windriver.com>

On Fri, 2019-01-04 at 15:15 +0800, Robert Yang wrote:
> Fixed:
> MACHINE = "qemux86"
> QEMU_USE_KVM = "qemux86"
> IMAGE_CLASSES += "testimage"
> 
> $ oe-selftest -r runqemu.RunqemuTests.test_boot_rootfs
> 
> [snip]
>   File "/buildarea1/lyang1/poky/meta/lib/oe/types.py", line 122, in
> boolean
>     raise ValueError("Invalid boolean value '%s'" % value)
> ValueError: Invalid boolean value 'qemux86'
> 
> Now QEMU_USE_KVM can only be boolean, can not contain MACHINE any
> more, kvm
> will be enabled if target_arch == build_arch or both of them are x86
> archs.
> 
[...]
> +def is_x86(arch):
> +    """
> +    Check whether arch is x86 or x86_64
> +    """
> +    if arch.startswith('x86_') or re.match('i.*86', arch) or arch ==
> 'ia64':
> +        return True

Thanks, I've queued this for testing. I did remove the ia64 test here
as ia64 is itanium which can't do x86 KVM from what I know.

We may also need to add something for arm == aarch64 comparisons, I'm
not 100% sure what is supproted. I've cc'd Jon on that...

Cheers,

Richard



  reply	other threads:[~2019-01-07 15:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04  7:15 [PATCH v2 0/3] oeqa: Fix for QEMU_USE_KVM Robert Yang
2019-01-04  7:15 ` [PATCH v2 1/3] " Robert Yang
2019-01-07 15:24   ` Richard Purdie [this message]
2019-01-04  7:15 ` [PATCH v2 2/3] oeqa/manual/bsp-qemu.json: Update " Robert Yang
2019-01-04  7:15 ` [PATCH v2 3/3] oeqa/selftest/runqemu: Enable kvm when QEMU_USE_KVM is set Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=036334051f2c318eb35e0983ffb3df3931757747.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Jon.Mason@arm.com \
    --cc=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox