Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] native.bbclass: remove invalid CONFIG_SITE
Date: Thu, 24 Jan 2019 12:51:04 +0000	[thread overview]
Message-ID: <03cc0bf2cf2d942dcd7c05b89e039499dbe617b3.camel@linuxfoundation.org> (raw)
In-Reply-To: <10d326febf6744315b0cb324b98b9f3bd9ea4056.1548313558.git.liezhi.yang@windriver.com>

On Thu, 2019-01-24 at 15:06 +0800, Robert Yang wrote:
> This CONFIG_SITE has no effect since autotools.bbclass handles it.
> And the
> comment line is out of date, it was for "CONFIG_SITE = ''", so remove
> them.

Going from memory, we had a problem where the path to sed was being
encoded into scripts (e.g. libtool/autotools and others). It may be
/usr/bin/sed on some systems and /bin/sed on others.

Are you sure this is no longer a problem?

Cheers,

Richard

> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/classes/native.bbclass | 3 ---
>  meta/site/native            | 1 -
>  2 files changed, 4 deletions(-)
>  delete mode 100644 meta/site/native
> 
> diff --git a/meta/classes/native.bbclass
> b/meta/classes/native.bbclass
> index ddccfe2..c20c6dc 100644
> --- a/meta/classes/native.bbclass
> +++ b/meta/classes/native.bbclass
> @@ -54,9 +54,6 @@ TOOLCHAIN_OPTIONS = ""
>  # Don't build ptest natively
>  PTEST_ENABLED = "0"
>  
> -# Don't use site files for native builds
> -export CONFIG_SITE = "${COREBASE}/meta/site/native"
> -
>  # set the compiler as well. It could have been set to something else
>  export CC = "${BUILD_CC}"
>  export CXX = "${BUILD_CXX}"
> diff --git a/meta/site/native b/meta/site/native
> deleted file mode 100644
> index 7dfb1cb..0000000
> --- a/meta/site/native
> +++ /dev/null
> @@ -1 +0,0 @@
> -ac_cv_path_SED=sed
> -- 
> 2.7.4
> 



  reply	other threads:[~2019-01-24 12:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-24  7:06 [PATCH 0/1] native.bbclass: remove invalid CONFIG_SITE Robert Yang
2019-01-24  7:06 ` [PATCH 1/1] " Robert Yang
2019-01-24 12:51   ` Richard Purdie [this message]
2019-01-25  2:40     ` Robert Yang
2019-01-25  2:55       ` Robert Yang
2019-01-25  2:59       ` Robert Yang
2019-01-25  3:07         ` Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03cc0bf2cf2d942dcd7c05b89e039499dbe617b3.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox