From: richard.purdie@linuxfoundation.org
To: Kai Kang <kai.kang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/6] update_font_cache: update script for multilib
Date: Tue, 04 Sep 2018 10:12:45 +0100 [thread overview]
Message-ID: <040ce37698d169827043fa7ca17e2509a45cd58f.camel@linuxfoundation.org> (raw)
In-Reply-To: <9ae08680d92897330510b0de660a9b2afc7d00bb.1535288685.git.kai.kang@windriver.com>
On Sun, 2018-08-26 at 06:06 -0700, Kai Kang wrote:
> Packages which inherit fontcache.bbclass call postinstall script
> update_font_cache. And in update_font_cache, it calls ${bindir}/fc-
> cache
> by qemuwrapper. When multilib is enabled, both packages foo and
> lib32-foo
> will call ${bindir}/fc-cache and one of them will fail to run
> obviously.
>
> Duplicate install file fc-cache to ${libexecdir} with ${MLPREFIX} and
> call proper fc-cache in update_font_cache.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
> meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb | 8 +++++++-
> scripts/postinst-intercepts/update_font_cache | 2 +-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb
> b/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb
> index d4cbce80b45..db36c867741 100644
> --- a/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb
> +++ b/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb
> @@ -35,9 +35,15 @@ do_configure_prepend() {
> rm -f ${S}/src/fcobjshash.h ${S}/src/fcobjshash.gperf
> }
>
> +do_install_append_class-target() {
> + # duplicate fc-cache for postinstall script
> + mkdir -p ${D}${libexecdir}
> + cp ${D}${bindir}/fc-cache ${D}${libexecdir}/${MLPREFIX}fc-cache
We may as well hardlink this, same for the following patch too.
Cheers,
Richard
next prev parent reply other threads:[~2018-09-04 9:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-26 13:06 [PATCH V4 0/6] allarch: disable allarch when multilib is used Kai Kang
2018-08-26 13:06 ` [PATCH 1/6] " Kai Kang
2018-09-04 8:36 ` richard.purdie
2018-09-04 9:07 ` Kang Kai
2018-09-05 2:52 ` Kang Kai
2018-09-05 21:34 ` richard.purdie
2018-08-26 13:06 ` [PATCH 2/6] sstate.bbclass: update SSTATE_DUPWHITELIST Kai Kang
2018-08-26 13:06 ` [PATCH 3/6] update_font_cache: update script for multilib Kai Kang
2018-09-04 9:12 ` richard.purdie [this message]
2018-09-04 9:41 ` Kang Kai
2018-08-26 13:06 ` [PATCH 4/6] update_gtk_immodules_cache: update " Kai Kang
2018-08-26 13:06 ` [PATCH 5/6] statetests.py: drop test_sstate_allarch_samesigs_multilib Kai Kang
2018-08-26 13:06 ` [PATCH 6/6] multilib: fix install file conflicts Kai Kang
2018-09-04 9:16 ` richard.purdie
2018-09-04 9:52 ` Kang Kai
2018-08-26 13:33 ` ✗ patchtest: failure for allarch: disable allarch when multilib is used (rev4) Patchwork
2018-08-26 13:58 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=040ce37698d169827043fa7ca17e2509a45cd58f.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox