RE: [OE-core] [PATCH v2 1/2] buildhistory: fix package output folder creation

Pedro Silva Ferreira
2024-08-27T12:50:12Z

Hi Steve and Richard,

I tried to backport locally patches [4] and [5] to kirkstone and scarthgap but i ran into some issues related to sstate.bbclass. After some investigation i saw that i was missing a patch done by Richard [3] in the context of this buildhistory change but after applying the patch [3], due to the `interceptfuncs` logic i ran into an undefined variable (SSTATE_INSTDIR) while executing `bb.utils.rename` helper function. Applying patch [1] and [2] in combination with [3] , [4] and [5] seems to do the job but im not really sure if patch [1] and [2] can be backported to lts branches since they remove some features/class that might be used by other components that I am not aware of. I tested this with ncurses recipe and with core-image-minimal.

1: siteconfig: Drop siteconfig class/code/support
f3766dc038f7ba9780ddaf5eb8d27385ea31d7d0
2: sstate: Drop intercept functions support
cfbfd0b2e89eb71783c55a1be4a7e63e6cd82c2f
3: sstate/buildhistory: Fix plaindirs handling to occur before SSTATEPOSTINSTFUNCS
62ee349cf18532dac8736488752c00e89de78fcd
4: buildhistory: Restoring files from preserve list
9f68a45aa238ae5fcdfaca71ba0e7015e9cb720e
5: buildhistory: Fix intermittent package file list creation
8de9b8c1e199896b9a7bc5ed64967c6bfbf84bea

My best regards,

Pedro

-----Original Message-----
From: Steve Sakoman <steve@sakoman.com>
Sent: Tuesday, August 13, 2024 1:09 PM
To: Pedro Silva Ferreira <Pedro.Silva.Ferreira@criticaltechworks.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH v2 1/2] buildhistory: fix package output folder creation

Notice: This e-mail has originated from an external email service, so do not click on any links, nor open any attachments unless you know who the sender is and are sure the content is secure.

On Tue, Aug 13, 2024 at 1:05 AM Pedro Ferreira via lists.openembedded.org <pedro.silva.ferreira=criticaltechworks.com@lists.openembedded.org>
wrote:
>
> Is it possible/feasible to backport this change to LTS branches

Please send patches for kirkstone and scarthgap and I will add them to my test queue.

I see that this resulted in some breakage in the master branch, so you should also include patches for any oe-core breakage.

Thanks!

Steve

> Thank you,
>
> Pedro Ferreira
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#203258):
> https://lists.openembedded.org/g/openembedded-core/message/203258
> Mute This Topic: https://lists.openembedded.org/mt/107750091/3620601
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
> [steve@sakoman.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
The information in this communication may contain confidential or legally privileged information. It is intended solely for the use of the individual or entity it addresses and others authorized to receive it. If you are not an intended recipient, you are hereby notified that any disclosure, copying, distribution or action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication by error, please notify us immediately by responding to this e-mail and then delete it from your system. Critical TechWorks is not liable for the proper and complete transmission of the information in this communication nor for any delay in its receipt

This e-mail is environmentally friendly, just like Critical TechWorks, which lives in a paper-free atmosphere. Therefore, please consider the environment before printing it!