From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: liezhi.yang@windriver.com, openembedded-core@lists.openembedded.org
Cc: alex.kanavin@gmail.com
Subject: Re: [OE-core] [PATCH v3 1/2] classes: Print bitbake branch and revision
Date: Tue, 17 Sep 2024 12:12:51 +0100 [thread overview]
Message-ID: <04e4a589de370a4c69c8cedd976866fc61779e6f.camel@linuxfoundation.org> (raw)
In-Reply-To: <ad2b2df4041f0c721d1a82de0fe759d896c6bfb6.1726065189.git.liezhi.yang@windriver.com>
On Wed, 2024-09-11 at 07:35 -0700, Robert Yang via lists.openembedded.org wrote:
> From: Robert Yang <liezhi.yang@windriver.com>
>
> There is no bitbake revision when it is in a separate repo, then we have no way
> to know which version of bitbake is used from the log, this patch always prints
> it.
>
> * console-latest.log
> bitbake = "master:165368bad152a14b32b5216b938aa4b915d72a70"
> meta
> meta-poky
> meta-yocto-bsp = "master:165368bad152a14b32b5216b938aa4b915d72a70"
I think this is confusing as it implies that revision is in the bitbake
repository which it isn't, that is a poky revision. The current output
tries to make that clear, this patch starts to confuse that.
We're really close to release and I'm not going to rush into changing
this so close to a release build. I don't mind printing a bitbake
revision but it should probably only be when it is a separate repo. The
change is too late for 5.1 IMO.
Cheers,
Richard
next prev parent reply other threads:[~2024-09-17 11:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 14:35 [PATCH v3 0/2] classes: Print bitbake branch and revision liezhi.yang
2024-09-11 14:35 ` [PATCH v3 1/2] " liezhi.yang
2024-09-17 11:12 ` Richard Purdie [this message]
2024-09-18 7:56 ` [OE-core] " Robert Yang
2024-09-11 14:36 ` [PATCH v3 2/2] lib/buildcfg: Add is_bitbake_in_separate_repo() liezhi.yang
2024-09-12 5:13 ` [OE-core] " Peter Kjellerstedt
2024-09-12 9:10 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04e4a589de370a4c69c8cedd976866fc61779e6f.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alex.kanavin@gmail.com \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox