From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gate.crashing.org ([63.228.1.57] ident=[U2FsdGVkX18WyxTYJDMM15ZTLwNrrdTPvV68o/sQXX8=]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Qw2Ov-0000vc-P3 for openembedded-core@lists.openembedded.org; Wed, 24 Aug 2011 03:37:06 +0200 Received: from [IPv6:::1] (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id p7O1VUd7024550; Tue, 23 Aug 2011 20:32:17 -0500 Mime-Version: 1.0 (Apple Message framework v1084) From: Kumar Gala In-Reply-To: Date: Tue, 23 Aug 2011 20:32:16 -0500 Message-Id: <0597F428-97F2-461F-804B-FE793E911BD4@kernel.crashing.org> References: To: "Xu, Dongxiao" X-Mailer: Apple Mail (2.1084) Cc: Patches and discussions about the oe-core layer Subject: Re: why do we poison -Os? X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2011 01:37:06 -0000 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable If tinylogin is the only issue why modify/patch gcc? I see we have = meta/recipes-core/tinylogin/tinylogin-1.4/use_O2_option.patch to deal = with this? Not allowing -Os at all, which is our current situation on PPC is = problematic. So trying to see if this issue is really limited to gcc = 4.5 or not. How can I reproduce it with current poky.git? - k On Aug 23, 2011, at 8:16 PM, Xu, Dongxiao wrote: > Hi Kumar, >=20 > The background of this commit is, when I upgraded PowerPC gcc to 4.5, = tinylogin would crash with certain GCC build parameters. >=20 > The root cause for that bug is, if enabled both "-frename-registers" = and "-Os" options to build tinylogin in powerpc architecture, the = tinylogin/getty application will encounter segmentation fault. Other = combinations like "-frename-registers and -O2" or only "-Os" will not = trigger this issue. >=20 > Poky cross environment provides the "-frename-registers" parameter, = however it does not provide -Os option since "--enable-target-optspace" = option is disabled for powerpc gcc. The "-Os" option in tinylogin is = added by its own Makefile. >=20 > This commit is to prevent the above case. If --enable-target-optspace = is disabled for GCC, "-Os" should not be added by recipe. >=20 > Thanks, > Dongxiao >=20 >> -----Original Message----- >> From: Kumar Gala [mailto:galak@kernel.crashing.org] >> Sent: Wednesday, August 24, 2011 8:53 AM >> To: Xu, Dongxiao >> Cc: Patches and discussions about the oe-core layer; Khem Raj >> Subject: why do we poison -Os? >>=20 >> Dongxiao, >>=20 >> Can you explain why this was needed: >>=20 >> commit ce456306dad3fdf42494830011dacae213c48edf >> Author: Dongxiao Xu >> Date: Sat Sep 25 10:16:26 2010 +0800 >>=20 >> gcc: enable poison parameters detection >>=20 >> If not configured with --enable-target-optspace, gcc will report >> errors if there is '-Os' optimization in parameters. >>=20 >> This fixes [BUGID #342] >>=20 >> Also add "--enable-target-optspace" option to arm gcc = configuration. >>=20 >> Signed-off-by: Dongxiao Xu >>=20 >>=20 >> - k