From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jonathan GUILLOT <jonathan@joggee.fr>, Ross Burton <Ross.Burton@arm.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v4 3/3] cups: use LOCALE_PATHS to split localized HTML templates
Date: Mon, 19 Feb 2024 15:10:55 +0000 [thread overview]
Message-ID: <05ba77f84bb9cad776f8c8f6be4e5141a46c990e.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAA_hxbS6hEY-QtBc7-2JOndevZfiLp3Ww4EoGFxUQDhsDfjBOg@mail.gmail.com>
On Mon, 2024-02-19 at 11:00 +0100, Jonathan GUILLOT wrote:
> Thanks Ross,
>
> I was too focus on English and French packages and missed this point.
> Listing all items in CUPS added locale path is not OK. I should at
> least only get directories (not files) in this path to create the
> locale list. However, it remains an issue if some directories in the
> path would not be dedicated to locales. This is not the point in CUPS
> but could be in an other recipe. Do you think it is possible to
> determine if the directory name is a valid language code? Is it
> reliable to consider locale directories will always be : 2-letter ISO
> 639 code followed by optional hyphen and ISO 3166 country code?
Fixing cups is the priority right now. I was hoping for a fix rather
than having to revert things.
Fixing the core code to only handle directories would also be good. We
should probably just note that all subdirectories are assumed to be
locales in a comment where LOCALE_PATHS is given it's default.
Cheers,
Richard
prev parent reply other threads:[~2024-02-19 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 14:50 [PATCH v4 0/3] lib/oe/package: allow to scan extra directories for locale files Jonathan GUILLOT
2023-11-30 12:49 ` [PATCH v4 1/3] lib/oe/package: replace in place PN-locale-* packages in PACKAGES Jonathan GUILLOT
2023-12-06 16:03 ` [PATCH v4 2/3] lib/oe/package: add LOCALE_PATHS to add define all locations for locales Jonathan GUILLOT
2023-12-06 16:06 ` [PATCH v4 3/3] cups: use LOCALE_PATHS to split localized HTML templates Jonathan GUILLOT
2024-02-15 16:27 ` [OE-core] " Ross Burton
2024-02-19 10:00 ` Jonathan GUILLOT
2024-02-19 15:10 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05ba77f84bb9cad776f8c8f6be4e5141a46c990e.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=Ross.Burton@arm.com \
--cc=jonathan@joggee.fr \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox