Re: [PATCH 00/11] clang-merge: Bring clang recipes from meta-clang

[Khem Raj <raj.khem@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 2907 bytes --]

On 4/24/25 3:04 AM, Dmitry Baryshkov wrote:
> On Thu, Apr 24, 2025 at 12:20:34AM -0700, Khem Raj wrote:
>> Latest mesa 25+ needs libclang during build for tools like mesa_clc,
>> we enahnced already existing llvm recipe to build pieces of clang as
>> well, which worked for mesa's needs but broke static clang compiler
>> provided by meta-clang due to newfound conflicts, since clang is now
>> built with llvm recipe from core and also by meta-clang and they
>> compete for same namespace, an attempt to make them co-habit did reveal
>> more difficulties. Clang compiler from meta-clang is not able to use
>> llvm libraries from core since they patch them differently.
>>
>> This patch series therefore brings clang and all recipes that build from
>> llvm sources into core. With this changeset, clang recipes can be removed
>> from meta-clang there is a pull request for that already [1]
>> As an aside, we only build clang once and use it for meta-clang needs
>> and core needs.
>>
>> With this, meta-clang can depend upon core layer to provide clang and
>> related recipes, meta-clang will still provide the toolchain policies
>> around clang based toolchains. Clang compiler from core, while usable
>> for mesa is not yet fully usable out of box, since we need to workout
>> the multi-toolchain architecture for core, which will be done in next
>> phase after this merge.
>>
>> [1] https://github.com/kraj/meta-clang/pull/1088
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> 
> After fixing the RPROVIDES, this still fails the nativesdk-mesa build if

clang recipe does have this

PROVIDES:append:class-native = " llvm-native libclc-native 
spirv-llvm-translator-native"
PROVIDES:append:class-target = " llvm libclc spirv-llvm-translator"
PROVIDES:append:class-nativesdk = " nativesdk-llvm nativesdk-libclc 
nativesdk-spirv-llvm-translator"


I wonder why is RPROVIDE needed.

> I enable OpenCL.
> 
> ERROR: QA Issue: File /usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/lib/libMesaOpenCL.so.1.0.0 in package nativesdk-libopencl-mesa contains reference to TMPDIR [buildpaths]
> 
> While building OpenCL-enabled Mesa:
> 
> /home/lumag/Projects/RPB/build-rpb/tmp-poky/work/cortexa57-poky-linux/mesa/25.0.2/recipe-sysroot/usr/include/llvm/ADT/DenseMapInfo.h:17:10: fatal error: 'cassert' file not found
> Unable to generate bindings: clang diagnosed error: /home/lumag/Projects/RPB/build-rpb/tmp-poky/work/cortexa57-poky-linux/mesa/25.0.2/recipe-sysroot/usr/include/llvm/ADT/DenseMapInfo.h:17:10: fatal error: 'cassert' file not found
 >

I do not see this error for qemux86-64 here ( maybe it happens for arm64 
targets alone ? ) I enabled opencl related pakageconfigs for 
nativesdk-mesa I added this line

PACKAGECONFIG:append:class-nativesdk = " libclc gallium-llvm amd svga"

and nativesdk-mesa built just fine.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 2613 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 203 bytes --]