From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: twoerner@gmail.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH v7 2/9] wic: move sample *wks files
Date: Fri, 06 Mar 2026 16:21:29 +0000 [thread overview]
Message-ID: <08808bc90a211c8ef9550cf3a30940629bc16299.camel@linuxfoundation.org> (raw)
In-Reply-To: <20260302003826.3995222-3-twoerner@gmail.com>
On Sun, 2026-03-01 at 19:38 -0500, Trevor Woerner via lists.openembedded.org wrote:
> By convention, wic will look for a "wic" directory in the top-level
> of all BBLAYERS in order to find *wks files. oe-core was the only
> exception; it stored its *wks files in scripts/lib/wic/canned-wks.
> Take the *wks, *wks.in, *inc, and *cfg files that were in the canned-
> wks location and place them in a "wic" top-level directory in the oe-
> core layer, thereby following the convention of every other layer.
This commit message is not strictly correct. The current code looks in
"wic" or "scripts/lib/wic/canned-wks" in every layer, not just oe-core.
You're dropping the scripts/lib/wic/canned-wks search location for all
layers.
I agree it is unlikely other layers are using that but the commit
message does need to be correct. That in turn will lead to better
migration notes for the release.
The bigger issue is that if this isn't documented correctly, what else
are the patches doing which I haven't spotted? :/.
Cheers,
Richard
next prev parent reply other threads:[~2026-03-06 16:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 0:38 [PATCH v7 0/9] standalone wic Trevor Woerner
2026-03-02 0:38 ` [PATCH v7 1/9] wic: re-implement sector-size support Trevor Woerner
2026-03-02 0:38 ` [PATCH v7 2/9] wic: move sample *wks files Trevor Woerner
2026-03-06 16:21 ` Richard Purdie [this message]
2026-03-07 8:59 ` [OE-core] " Scott Murray
2026-03-07 9:52 ` Richard Purdie
2026-03-02 0:38 ` [PATCH v7 3/9] wic: move to standalone repository Trevor Woerner
2026-03-02 0:38 ` [PATCH v7 4/9] wic: add recipe Trevor Woerner
2026-03-02 0:38 ` [PATCH v7 5/9] oe-selftest/cases/wic.py: update WicTestCase Trevor Woerner
2026-03-02 0:38 ` [PATCH v7 6/9] oe-selftest/cases/wic.py: oe-selftest -r wic.CLITests -> PASS Trevor Woerner
2026-03-02 0:38 ` [PATCH v7 7/9] oe-selftest/cases/wic.py: oe-selftest -r wic.ModifyTests " Trevor Woerner
2026-03-02 0:38 ` [PATCH v7 8/9] oe-selftest/cases/wic.py: oe-selftest -r wic.Wic " Trevor Woerner
2026-03-06 17:11 ` [OE-core] " Richard Purdie
2026-03-02 0:38 ` [PATCH v7 9/9] oe-selftest/cases/wic.py: oe-selftest -r wic.Wic2 " Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08808bc90a211c8ef9550cf3a30940629bc16299.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=twoerner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox