Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: alex.kanavin@gmail.com, ohnatiuk@cisco.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] package: disable renamed dependency error if allarch is overridden
Date: Tue, 20 May 2025 14:23:26 +0100	[thread overview]
Message-ID: <089fb60e663c2cd5f378fc12acd37d7a718bd458.camel@linuxfoundation.org> (raw)
In-Reply-To: <CANNYZj9mqhhwvr145RCzR5NULK48_SmphXyiprLFbK9dOGnyhw@mail.gmail.com>

On Tue, 2025-05-20 at 15:06 +0200, Alexander Kanavin via lists.openembedded.org wrote:
> On Mon, 19 May 2025 at 12:24, Oleksandr Hnatiuk via
> lists.openembedded.org <ohnatiuk=cisco.com@lists.openembedded.org>
> wrote:
> > 
> > Also, consider this
> > 
> > packagegroup.bbclass inherits allarch.bbclass - except when PACKAGE_ARCH is set before inheriting packagegroup
> > in order to do so, a nativesdk packagegroup must inherit nativesdk first
> > there is a native-last QA check which strongly suggests inheriting nativesdk last
> > nativesdk is inherited last via inherit_defer in nativesdk-packagegroup-sdk-host
> > 
> > I see all of this as either very misleading at best or a mistake at worst.
> 
> This is probably true. It does look like a pile of ad hoc fixups
> rather than an overall design and structure. Maybe it's possible to
> clean and simplify?
> 
>  I'd say if you resubmit the patch with all the extra research you did
> in the commit message, that would help review. I don't have objections
> anymore.

There is a lot of history here. I'm tempted to suggest we remove the
allarch inherit from packagegroup and add it to the recipes explicitly
as it is all getting far too convoluted and I'd like to see things
simplified, not complicated.

I'd like to see the conditional code in allarch removed too FWIW if we
can work out how to do it.

Cheers,

Richard



  reply	other threads:[~2025-05-20 13:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09 21:19 [PATCH] package: disable renamed dependency error if allarch is overridden Oleksandr Hnatiuk
2025-05-12  9:02 ` [OE-core] " Alexander Kanavin
2025-05-12  9:31   ` Oleksandr Hnatiuk
2025-05-12  9:40     ` [OE-core] " Alexander Kanavin
2025-05-13 10:30       ` Oleksandr Hnatiuk
2025-05-14 13:16         ` [OE-core] " Alexander Kanavin
2025-05-14 15:35           ` Oleksandr Hnatiuk
2025-05-15 12:55             ` [OE-core] " Alexander Kanavin
2025-05-19 10:13               ` Oleksandr Hnatiuk
2025-05-19 10:24                 ` Oleksandr Hnatiuk
2025-05-20 13:06                   ` [OE-core] " Alexander Kanavin
2025-05-20 13:23                     ` Richard Purdie [this message]
2025-07-10 15:02                     ` Oleksandr Hnatiuk
2025-07-11 17:42                       ` [OE-core] " Alexander Kanavin
2025-07-25 19:24                         ` Oleksandr Hnatiuk
2025-07-26 22:00                           ` [OE-core] " Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=089fb60e663c2cd5f378fc12acd37d7a718bd458.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alex.kanavin@gmail.com \
    --cc=ohnatiuk@cisco.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox