From: Khem Raj <raj.khem@gmail.com>
To: Jack Mitchell <ml@embed.me.uk>
Cc: Jack Mitchell <jack@embed.me.uk>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] file: specify c std as c99 or greater required
Date: Tue, 6 Sep 2016 11:36:45 -0700 [thread overview]
Message-ID: <09320575-0DBA-4F48-B349-7E99F6050A54@gmail.com> (raw)
In-Reply-To: <20160906132520.12562-1-ml@embed.me.uk>
[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]
> On Sep 6, 2016, at 6:25 AM, Jack Mitchell <ml@embed.me.uk> wrote:
>
> From: Jack Mitchell <jack@embed.me.uk>
>
> when using a toolchain not shipped by OE core such as linaro we
> can't be sure what the std will be set to. Ensure file is compiled
> as c99 or greater as required.
comment does not match the code, its using gnu11, secondly is gnu11 needed or can it live with
c11
>
> Signed-off-by: Jack Mitchell <jack@embed.me.uk>
> ---
> meta/recipes-devtools/file/file_5.28.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/file/file_5.28.bb b/meta/recipes-devtools/file/file_5.28.bb
> index 516c8c5..94848db 100644
> --- a/meta/recipes-devtools/file/file_5.28.bb
> +++ b/meta/recipes-devtools/file/file_5.28.bb
> @@ -27,6 +27,8 @@ inherit autotools
> EXTRA_OEMAKE_append_class-target = "-e FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
> EXTRA_OEMAKE_append_class-nativesdk = "-e FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
>
> +CFLAGS_append = " -std=gnu11"
> +
> FILES_${PN} += "${datadir}/misc/*.mgc"
>
> do_install_append_class-native() {
> --
> 2.9.3
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
next prev parent reply other threads:[~2016-09-06 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 13:25 [PATCH] file: specify c std as c99 or greater required Jack Mitchell
2016-09-06 18:36 ` Khem Raj [this message]
2016-09-06 18:49 ` Jack Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09320575-0DBA-4F48-B349-7E99F6050A54@gmail.com \
--to=raj.khem@gmail.com \
--cc=jack@embed.me.uk \
--cc=ml@embed.me.uk \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox