public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Frederic Martinsons <frederic.martinsons@gmail.com>,
	 openembedded-core@lists.openembedded.org
Cc: alex.kiernan@gmail.com
Subject: Re: [OE-core] [PATCH 0/5] Extend cargo based recip support
Date: Mon, 27 Mar 2023 15:20:17 +0100	[thread overview]
Message-ID: <094a85975f9b1ef0fc622f4f0acc70a935f1e6fe.camel@linuxfoundation.org> (raw)
In-Reply-To: <cover.1679734210.git.frederic.martinsons@gmail.com>

On Sat, 2023-03-25 at 10:00 +0100, Frederic Martinsons wrote:
> From: Frederic Martinsons <frederic.martinsons@gmail.com>
> 
> This series brings the support of local git repository inside
> a cargo based recipe.
> 
> It also enable devtool capacity on it and provide a real crate
> example recipe to show how things are done.
> 
> The following changes since commit 4876189dd2ae5a04a296b11b537b9f613159c6bf:
> 
>   xcb-proto: Fix install conflict when enable multilib. (2023-03-23 22:38:41 +0000)
> 
> are available in the Git repository at:
> 
>   https://gitlab.com/fmartinsons/openembedded-core cargo-extend-support-git-and-devtool
> 
> Alex Kiernan (1):
>   cargo_common.bbclass: Support local github repos
> 
> Frederic Martinsons (4):
>   cargo_common.bbclass: add support of user in url for patch
>   rust-example: provide a recipe for zvariant
>   devtool: add support for multiple git url inside a cargo based recipe
>   patch: support of git patches when the source uri contained subpath
>     param

The various rust/cargo/crate patches look like they're heading in a
good direction, thanks!

The one thing which I think is missing is more support for testing some
of these changes in our automated testing.

In particular, devtool does have a decent test suite so we should
ensure new devtool additions have tests.

You can see the devtools tests in
meta/lib/oeqa/selftest/cases/devtool.py and run them with a command
like "oe-selftest -r devtool -j 3" for example.

Cheers,

Richard


  parent reply	other threads:[~2023-03-27 14:20 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-25  9:00 [PATCH 0/5] Extend cargo based recip support frederic.martinsons
2023-03-25  9:00 ` [PATCH 1/5] cargo_common.bbclass: Support local github repos frederic.martinsons
2023-03-25  9:00 ` [PATCH 2/5] cargo_common.bbclass: add support of user in url for patch frederic.martinsons
2023-03-25  9:00 ` [PATCH 3/5] rust-example: provide a recipe for zvariant frederic.martinsons
2023-03-25 18:51   ` [OE-core] " Alexander Kanavin
2023-03-25 20:43     ` Frédéric Martinsons
2023-03-26 16:55       ` Alexander Kanavin
2023-03-27  4:09         ` Frédéric Martinsons
2023-03-27  6:40           ` Alexander Kanavin
2023-03-27  8:18             ` Alex Kiernan
2023-03-27  8:30               ` Frédéric Martinsons
2023-03-27  8:42                 ` Alex Kiernan
2023-03-27  8:52                   ` Frédéric Martinsons
2023-03-27 10:24                     ` Alex Kiernan
2023-03-25  9:00 ` [PATCH 4/5] devtool: add support for multiple git url inside a cargo based recipe frederic.martinsons
2023-03-25 18:55   ` [OE-core] " Alexander Kanavin
2023-03-26  5:15     ` Frédéric Martinsons
2023-03-25 19:02   ` Alexander Kanavin
2023-03-26  5:15     ` Frédéric Martinsons
2023-03-26 14:58       ` Frédéric Martinsons
2023-03-26 18:01         ` Alexander Kanavin
2023-03-27  4:09           ` Frédéric Martinsons
2023-03-25  9:00 ` [PATCH 5/5] patch: support of git patches when the source uri contained subpath param frederic.martinsons
2023-03-27 14:20 ` Richard Purdie [this message]
2023-03-27 14:25   ` [OE-core] [PATCH 0/5] Extend cargo based recip support Alexander Kanavin
2023-03-27 15:01     ` Frédéric Martinsons
2023-03-27 17:19       ` Alexander Kanavin
2023-03-27 18:07         ` Frédéric Martinsons
2023-03-27 18:30           ` Alex Kiernan
2023-03-27 18:40             ` Frédéric Martinsons
2023-03-27 18:52               ` Alex Kiernan
2023-03-27 19:00                 ` Alexander Kanavin
2023-03-27 19:20                   ` Frédéric Martinsons
2023-03-27 22:13                     ` Alexander Kanavin
2023-03-28  7:11                       ` Alex Kiernan
2023-03-28  8:37                         ` Alexander Kanavin
2023-03-28  9:01                           ` Alex Kiernan
2023-03-29 12:35                       ` Alex Kiernan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=094a85975f9b1ef0fc622f4f0acc70a935f1e6fe.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alex.kiernan@gmail.com \
    --cc=frederic.martinsons@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox