public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Ross Burton <Ross.Burton@arm.com>
To: "hongxu.jia@windriver.com" <hongxu.jia@windriver.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/2] flac: fix compile failed on musl
Date: Mon, 19 Jan 2026 18:07:44 +0000	[thread overview]
Message-ID: <0D264EDA-C778-4ADE-8307-ADDB7525CE97@arm.com> (raw)
In-Reply-To: <20260113124504.961856-1-hongxu.jia@windriver.com>



> On 13 Jan 2026, at 12:45, hongxu via lists.openembedded.org <hongxu.jia=windriver.com@lists.openembedded.org> wrote:
> 
> $ echo "TCLIBC = 'musl'" >> conf/local.conf
> $ echo "MACHINE = 'qemux86'" >> conf/local.conf
> $ bitbake flac
> ...
> | libtool: link: (cd .libs/libFLAC++-static.lax/libFLAC-static.a && i686-oe-linux-musl-gcc-arx
> "/buildarea5/hjia/oe-core/build/tmp/work/core2-32-oe-linux-musl/flac/1.5.0/build/src/libFLAC++/
> ../libFLAC/.libs/libFLAC-static.a")
> | build/tmp/work/core2-32-oe-linux-musl/flac/1.5.0/recipe-sysroot-native/usr/bin/
> i686-oe-linux-musl/../../libexec/i686-oe-linux-musl/gcc/i686-oe-linux-musl/15.2.0/ld:
> .libs/metadata.o: in function `FLAC::Metadata::VorbisCo
> mment::set_comment(unsigned int, FLAC::Metadata::VorbisComment::Entry const&)':
> | /usr/src/debug/flac/1.5.0/src/libFLAC++/metadata.cpp:913:(.text+0x2032): undefined reference to `__stack_chk_fail_local'
> ...
> 
> Disable stack smash protection to workaround the failure

Disabling stack smash protection in a library whose sole job is to parse untrusted files sounds dangerous. Can we just fix the linkage instead?

If this is a case where musl doesn’t implement enough support for GCC’s functionality then the disabling should probably be done globally in security_flags.inc with good references as to why that is being done.

Ross

      parent reply	other threads:[~2026-01-19 18:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 12:45 [PATCH 1/2] flac: fix compile failed on musl Hongxu Jia
2026-01-13 12:45 ` [PATCH 2/2] webkitgtk: upgrade 2.50.0 -> 2.50.4 Hongxu Jia
2026-01-13 15:25   ` [OE-core] " Alexander Kanavin
2026-01-14  2:15     ` Hongxu Jia
     [not found]     ` <188A774745AD7FE0.3093368@lists.openembedded.org>
2026-01-19  2:26       ` Hongxu Jia
2026-01-19 12:45         ` Alexander Kanavin
2026-01-19 18:07 ` Ross Burton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0D264EDA-C778-4ADE-8307-ADDB7525CE97@arm.com \
    --to=ross.burton@arm.com \
    --cc=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox